Re: [PATCH v2 3/8] arm: add device-tree SoC bindings for Axis Artpec-6

Arnd Bergmann
2016-02-11T14:14:56Z

On Thursday 11 February 2016 15:04:37 Lars Persson wrote:
> +
> +The DMA configuration unit muxes dma request lines between single and burst
> +alternatives.
> +
> +Required properties:
> +- compatible: axis,artpec6-dmacfg
> +- reg: Address and length of DMACFG register.
> +
> +Example:
> + dmacfg {
> + compatible = "axis,artpec6-dmacfg";
> + reg = <0xf8000010 4>;
> + };
> +

This method looks better than before, but putting a single register
into DT looks wrong. I can almost guarantee that there are more
registers at 0xf8000000-0xf8000fff (or more) that belong to either
some system controller or a DMA controller.

Whatever it is, please describe it in the DT in a sensible way based
on what the hardware does and what other resources it uses (interrupts
etc) rather than what today's kernel happens to need.

Arnd