From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailoutvs47.siol.net ([185.57.226.238]:50459 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753026AbeF2TQg (ORCPT ); Fri, 29 Jun 2018 15:16:36 -0400 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai Cc: Maxime Ripard , Rob Herring , David Airlie , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Mark Rutland , dri-devel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi Subject: Re: [linux-sunxi] [PATCH v3 06/24] drm/sun4i: Fix releasing node when enumerating enpoints Date: Fri, 29 Jun 2018 21:15:06 +0200 Message-ID: <3837144.KdEe8HRubn@jernej-laptop> In-Reply-To: References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180625120304.7543-7-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org List-ID: Dne Ĩetrtek, 28. junij 2018 ob 03:53:36 CEST je Chen-Yu Tsai napisal(a): > On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec wrote: > > sun4i_drv_add_endpoints() has a memory leak since it uses of_node_put() > > when remote is equal to NULL and does nothing when remote has a valid > > pointer. > > > > Invert the logic to fix memory leak. > > > > Signed-off-by: Jernej Skrabec > > Given this is a fix, it should have Fixes and stable tags. How should be this handled given that the patch is already merged and cannot be dropped? Best regards, Jernej