From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E45DC41535 for ; Fri, 3 Nov 2023 15:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232640AbjKCPXl (ORCPT ); Fri, 3 Nov 2023 11:23:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbjKCPXk (ORCPT ); Fri, 3 Nov 2023 11:23:40 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1CC58112; Fri, 3 Nov 2023 08:23:38 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AECC2F4; Fri, 3 Nov 2023 08:24:20 -0700 (PDT) Received: from [10.57.81.32] (unknown [10.57.81.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6FC03F64C; Fri, 3 Nov 2023 08:23:31 -0700 (PDT) Message-ID: <3b4ac48b-e29d-415f-89f1-6d354f18c4a4@arm.com> Date: Fri, 3 Nov 2023 15:23:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64 Content-Language: en-GB To: Mark Brown , =?UTF-8?Q?Duje_Mihanovi=C4=87?= Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Leo Yan , Zhangfei Gao , Lubomir Rintel , Catalin Marinas , Will Deacon , Kees Cook , Tony Luck , "Guilherme G . Piccoli" , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej , kernel test robot References: <20231102152033.5511-1-duje.mihanovic@skole.hr> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2023-11-02 3:26 pm, Mark Brown wrote: > On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote: >> The SSPA driver currently seems to generate ARM32 assembly, which causes >> build errors when building a kernel for an ARM64 ARCH_MMP platform. >> >> Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support") >> Reported-by: kernel test robot > >> tristate "SoC Audio via MMP SSPA ports" >> - depends on ARCH_MMP >> + depends on ARCH_MMP && ARM > > This isn't a fix for the existing code, AFAICT the issue here is that > ARCH_MMP is currently only available for arm and presumably something in > the rest of your series makes it available for arm64. This would be a > prerequisite for that patch. > > Please don't just insert random fixes tags just because you can. FWIW it doesn't even seem to be the right reason either. AFACIT the issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which depends on ARM, but after patch #8 ARCH_MMP itself will no longer necessarily imply ARM. The fact that selecting SND_ARM with unmet dependencies also allows SND_ARMAACI to be enabled (which appears to be the only thing actually containing open-coded Arm asm) is tangential. Robin.