Re: [RFC PATCH v2 2/4] dt-bindings: clock: Add R9A09G057 core clocks

Lad, Prabhakar
2024-06-13T09:57:43Z

Hi Krzysztof,

Thank you for the review.

On Tue, Jun 11, 2024 at 7:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 11/06/2024 01:32, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Define RZ/V2H(P) (R9A09G057) Clock Pulse Generator core clocks.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v1->v2
> > - Dropped the module clocks and just added the core clocks
> >
> > Note the core clocks are the once which are listed as part
> > of section 4.4.2 which cannot be controlled by CLKON register.
> > ---
> > include/dt-bindings/clock/r9a09g057-cpg.h | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100644 include/dt-bindings/clock/r9a09g057-cpg.h
>
> Missing vendor prefix.
>
OK, Is this just for new includes being added, or do you want me to
rename the existing Renesas specific includes in here which dont have
vendor prefix?

> This belongs to the binding patch, so squash it.
>
OK, I will squash it.

Cheers,
Prabhakar