RE: [PATCH 4/6] thermal: renesas: rzg3s: Add thermal driver for the Renesas RZ/G3S SoC

Biju Das
2025-01-27T09:17:45Z

Hi Claudiu,

> -----Original Message-----
> From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> Sent: 27 January 2025 09:16
> Subject: Re: [PATCH 4/6] thermal: renesas: rzg3s: Add thermal driver for the Renesas RZ/G3S SoC
>
> Hi, Biju,
>
> On 27.01.2025 11:11, Biju Das wrote:
> > Hi Claudiu,
> >
> >> -----Original Message-----
> >> From: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Sent: 27 January 2025 08:55
> >> Subject: Re: [PATCH 4/6] thermal: renesas: rzg3s: Add thermal driver
> >> for the Renesas RZ/G3S SoC
> >>
> >> Hi Claudiu,
> >>
> >> On Mon, 27 Jan 2025 at 09:33, Claudiu Beznea <claudiu.beznea@tuxon.dev> wrote:
> >>> On 25.01.2025 14:18, Jonathan Cameron wrote:
> >>>> On Wed, 22 Jan 2025 11:29:19 +0100
> >>>> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >>>>> On Fri, Jan 3, 2025 at 5:38 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> >>>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >>>>>>
> >>>>>> The Renesas RZ/G3S SoC features a Thermal Sensor Unit (TSU) that
> >>>>>> reports the junction temperature. The temperature is reported
> >>>>>> through a dedicated ADC channel. Add a driver for the Renesas RZ/G3S TSU.
> >>>>>>
> >>>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >>>>>
> >>>>> Thanks for your patch!
> >>>>>
> >>>>>> --- /dev/null
> >>>>>> +++ b/drivers/thermal/renesas/rzg3s_thermal.c
> >>>>>
> >>>>>> +static int rzg3s_thermal_probe(struct platform_device *pdev) {
> >>>>>> + struct rzg3s_thermal_priv *priv;
> >>>>>> + struct device *dev = &pdev->dev;
> >>>>>> + int ret;
> >>>>>> +
> >>>>>> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> >>>>>> + if (!priv)
> >>>>>> + return -ENOMEM;
> >>>>>> +
> >>>>>> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> >>>>>> + if (IS_ERR(priv->base))
> >>>>>> + return PTR_ERR(priv->base);
> >>>>>> +
> >>>>>> + priv->channel = devm_iio_channel_get(dev, "tsu");
> >>>>>
> >>>>> Given there's only a single IIO channel, you could pass NULL
> >>>>> instead of the name, and drop "io-channel-names" from the DT bindings.
> >>>>> I don't know what's the IIO policy w.r.t. unnamed channels, though.
> >>>>
> >>>> It's supported, so fine as long as no future additional names show up.
> >>>> Will just fallback to index 0 I think.
> >>>
> >>> If everyone agrees, I would keep the name, too, to avoid
> >>> complications in case this IP variant will be extended on future SoCs.
> >
> > If you are planning to extend this driver to other SoCs then may be
> > update
>
> I don't plan to extend it. My point here was to keep the driver as is for any possible future
> extensions that might arise.

OK, then it is fine as the driver is only for RZ/G3S SoC.

Cheers,
Biju