Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

David Gow
2023-03-02T08:14:11Z

[-- Attachment #1: Type: text/plain, Size: 5227 bytes --]

On Thu, 2 Mar 2023 at 09:38, Stephen Boyd <sboyd@kernel.org> wrote:
>
> This patch series adds unit tests for the clk fixed rate basic type and
> the clk registration functions that use struct clk_parent_data. To get
> there, we add support for loading a DTB into the UML kernel that's
> running the unit tests along with probing platform drivers to bind to
> device nodes specified in DT.
>
> With this series, we're able to exercise some of the code in the common
> clk framework that uses devicetree lookups to find parents and the fixed
> rate clk code that scans devicetree directly and creates clks. Please
> review.
>

Thanks Stephen -- this is really neat!

This works well here, and I love all of the tests for the
KUnit/device-tree integration as well.

I'm still looking through the details of it (alas, I've mostly lived
in x86-land, so my device-tree knowledge is, uh, spotty to say the
least), but apart from possibly renaming some things or similarly
minor tweaks, I've not got any real suggestions thus far.

I do wonder whether we'll want, on the KUnit side, to have some way of
supporting KUnit device trees on non-UML architecctures (e.g., if we
need to test something architecture-specific, or on a big-endian
platform, etc), but I think that's a question for the future, rather
than something that affects this series.

Similarly, I wonder if there's something we could do with device tree
overlays, in order to make it possible for tests to swap nodes in and
out for testing.

I don't think either of those ideas should block this from getting in though.

> I Cced everyone to all the patches so they get the full context. I'm
> hoping I can take the whole pile through the clk tree as they almost all
> depend on each other. In the future I imagine it will be easy to add
> more test nodes to the clk.dtsi file and not need to go across various
> maintainer trees like this series does.

That seems pretty sensible to me. I expect there'll be a few minor
conflicts on the KUnit side (there are a bunch of small
lib/kunit/Makefile changes in 6.3, and there's a plan to do some more
serious changes to the kunit_resource API at some point, though I have
my doubts they'll all hit in 6.4), but I doubt they'll cause too much
strife.

Cheers,
-- David

>
> Stephen Boyd (8):
> dt-bindings: Add linux,kunit binding
> of: Enable DTB loading on UML for KUnit tests
> kunit: Add test managed platform_device/driver APIs
> clk: Add test managed clk provider/consumer APIs
> dt-bindings: kunit: Add fixed rate clk consumer test
> clk: Add KUnit tests for clk fixed rate basic type
> dt-bindings: clk: Add KUnit clk_parent_data test
> clk: Add KUnit tests for clks registered with struct clk_parent_data
>
> .../clock/linux,clk-kunit-parent-data.yaml | 47 ++
> .../kunit/linux,clk-kunit-fixed-rate.yaml | 35 ++
> .../bindings/kunit/linux,kunit.yaml | 24 +
> arch/um/kernel/dtb.c | 29 +-
> drivers/clk/.kunitconfig | 3 +
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 6 +
> drivers/clk/clk-fixed-rate_test.c | 296 ++++++++++++
> drivers/clk/clk-kunit.c | 204 ++++++++
> drivers/clk/clk-kunit.h | 28 ++
> drivers/clk/clk_test.c | 456 +++++++++++++++++-
> drivers/of/Kconfig | 26 +
> drivers/of/Makefile | 1 +
> drivers/of/kunit/.kunitconfig | 4 +
> drivers/of/kunit/Makefile | 4 +
> drivers/of/kunit/clk.dtsi | 30 ++
> drivers/of/kunit/kunit.dtsi | 9 +
> drivers/of/kunit/kunit.dtso | 4 +
> drivers/of/kunit/uml_dtb_test.c | 55 +++
> include/kunit/platform_driver.h | 15 +
> lib/kunit/Makefile | 6 +
> lib/kunit/platform_driver-test.c | 107 ++++
> lib/kunit/platform_driver.c | 207 ++++++++
> 23 files changed, 1599 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/linux,clk-kunit-parent-data.yaml
> create mode 100644 Documentation/devicetree/bindings/kunit/linux,clk-kunit-fixed-rate.yaml
> create mode 100644 Documentation/devicetree/bindings/kunit/linux,kunit.yaml
> create mode 100644 drivers/clk/clk-fixed-rate_test.c
> create mode 100644 drivers/clk/clk-kunit.c
> create mode 100644 drivers/clk/clk-kunit.h
> create mode 100644 drivers/of/kunit/.kunitconfig
> create mode 100644 drivers/of/kunit/Makefile
> create mode 100644 drivers/of/kunit/clk.dtsi
> create mode 100644 drivers/of/kunit/kunit.dtsi
> create mode 100644 drivers/of/kunit/kunit.dtso
> create mode 100644 drivers/of/kunit/uml_dtb_test.c
> create mode 100644 include/kunit/platform_driver.h
> create mode 100644 lib/kunit/platform_driver-test.c
> create mode 100644 lib/kunit/platform_driver.c
>
>
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]