Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

Frank Rowand
2023-03-04T15:50:35Z

On 3/1/23 19:38, Stephen Boyd wrote:
> This patch series adds unit tests for the clk fixed rate basic type and
> the clk registration functions that use struct clk_parent_data. To get
> there, we add support for loading a DTB into the UML kernel that's
> running the unit tests along with probing platform drivers to bind to
> device nodes specified in DT.
>
> With this series, we're able to exercise some of the code in the common
> clk framework that uses devicetree lookups to find parents and the fixed
> rate clk code that scans devicetree directly and creates clks. Please
> review.

I would _really_ like to _not_ have devicetree tests in two locations:
DT unittests and kunit tests.

For my testing, I already build and boot four times on real hardware:

1) no DT unittests
2) CONFIG_OF_UNITTEST
3) CONFIG_OF_UNITTEST
CONFIG_OF_DYNAMIC
4) CONFIG_OF_UNITTEST
CONFIG_OF_DYNAMIC
CONFIG_OF_OVERLAY

I really should also be testing the four configurations on UML, but at
the moment I am not.

I also check for new compile warnings at various warn levels for all
four configurations.

If I recall correctly, the kunit framework encourages more (many more?)
kunit config options to select which test(s) are build for a test run.
Someone please correct this paragraph if I am mis-stating.

Adding devicetree tests to kunit adds additional build and boot cycles
and additional test output streams to verify.

Are there any issues with DT unittests that preclude adding clk tests
into the DT unittests?

-Frank

>
> I Cced everyone to all the patches so they get the full context. I'm
> hoping I can take the whole pile through the clk tree as they almost all
> depend on each other. In the future I imagine it will be easy to add
> more test nodes to the clk.dtsi file and not need to go across various
> maintainer trees like this series does.
>
> Stephen Boyd (8):
> dt-bindings: Add linux,kunit binding
> of: Enable DTB loading on UML for KUnit tests
> kunit: Add test managed platform_device/driver APIs
> clk: Add test managed clk provider/consumer APIs
> dt-bindings: kunit: Add fixed rate clk consumer test
> clk: Add KUnit tests for clk fixed rate basic type
> dt-bindings: clk: Add KUnit clk_parent_data test
> clk: Add KUnit tests for clks registered with struct clk_parent_data
>
> .../clock/linux,clk-kunit-parent-data.yaml | 47 ++
> .../kunit/linux,clk-kunit-fixed-rate.yaml | 35 ++
> .../bindings/kunit/linux,kunit.yaml | 24 +
> arch/um/kernel/dtb.c | 29 +-
> drivers/clk/.kunitconfig | 3 +
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 6 +
> drivers/clk/clk-fixed-rate_test.c | 296 ++++++++++++
> drivers/clk/clk-kunit.c | 204 ++++++++
> drivers/clk/clk-kunit.h | 28 ++
> drivers/clk/clk_test.c | 456 +++++++++++++++++-
> drivers/of/Kconfig | 26 +
> drivers/of/Makefile | 1 +
> drivers/of/kunit/.kunitconfig | 4 +
> drivers/of/kunit/Makefile | 4 +
> drivers/of/kunit/clk.dtsi | 30 ++
> drivers/of/kunit/kunit.dtsi | 9 +
> drivers/of/kunit/kunit.dtso | 4 +
> drivers/of/kunit/uml_dtb_test.c | 55 +++
> include/kunit/platform_driver.h | 15 +
> lib/kunit/Makefile | 6 +
> lib/kunit/platform_driver-test.c | 107 ++++
> lib/kunit/platform_driver.c | 207 ++++++++
> 23 files changed, 1599 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/linux,clk-kunit-parent-data.yaml
> create mode 100644 Documentation/devicetree/bindings/kunit/linux,clk-kunit-fixed-rate.yaml
> create mode 100644 Documentation/devicetree/bindings/kunit/linux,kunit.yaml
> create mode 100644 drivers/clk/clk-fixed-rate_test.c
> create mode 100644 drivers/clk/clk-kunit.c
> create mode 100644 drivers/clk/clk-kunit.h
> create mode 100644 drivers/of/kunit/.kunitconfig
> create mode 100644 drivers/of/kunit/Makefile
> create mode 100644 drivers/of/kunit/clk.dtsi
> create mode 100644 drivers/of/kunit/kunit.dtsi
> create mode 100644 drivers/of/kunit/kunit.dtso
> create mode 100644 drivers/of/kunit/uml_dtb_test.c
> create mode 100644 include/kunit/platform_driver.h
> create mode 100644 lib/kunit/platform_driver-test.c
> create mode 100644 lib/kunit/platform_driver.c
>
>
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c