From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412A9C4332F for ; Wed, 23 Nov 2022 14:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238640AbiKWOaD (ORCPT ); Wed, 23 Nov 2022 09:30:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238645AbiKWO3l (ORCPT ); Wed, 23 Nov 2022 09:29:41 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 154842739; Wed, 23 Nov 2022 06:27:30 -0800 (PST) Received: from [10.18.29.47] (10.18.29.47) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Wed, 23 Nov 2022 22:27:28 +0800 Message-ID: <3d657951-cbdf-07d6-4c73-7650381695a5@amlogic.com> Date: Wed, 23 Nov 2022 22:27:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH V5 4/4] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT Content-Language: en-US To: , Krzysztof Kozlowski , , , , , , Rob Herring , Neil Armstrong , Jerome Brunet , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl CC: References: <20221123021346.18136-1-yu.tu@amlogic.com> <20221123021346.18136-5-yu.tu@amlogic.com> <9961d579-9463-c585-34a6-a3abcd4b3e52@linaro.org> <7f3a34a0-a5b0-3a72-8e0e-00656bd77ff6@linaro.org> <2153a111-d5f0-94cf-9cfc-f8ce4b084a1c@linaro.org> From: Yu Tu In-Reply-To: <2153a111-d5f0-94cf-9cfc-f8ce4b084a1c@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.47] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2022/11/23 22:21, neil.armstrong@linaro.org wrote: > [ EXTERNAL EMAIL ] > > On 23/11/2022 15:13, Krzysztof Kozlowski wrote: >> On 23/11/2022 14:27, Neil Armstrong wrote: >>> On 23/11/2022 11:10, Krzysztof Kozlowski wrote: >>>> On 23/11/2022 03:13, Yu Tu wrote: >>>>> Added information about the S4 SOC Peripheral Clock controller in DT. >>>>> >>>>> Signed-off-by: Yu Tu >>>>> --- >>>>>    arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 26 >>>>> +++++++++++++++++++++++ >>>>>    1 file changed, 26 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>> b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>> index bd9c2ef83314..e7fab6e400be 100644 >>>>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>> @@ -6,6 +6,8 @@ >>>>>    #include >>>>>    #include >>>>>    #include >>>>> +#include >>>>> +#include >>>>>    / { >>>>>        cpus { >>>>> @@ -100,6 +102,30 @@ clkc_pll: clock-controller@8000 { >>>>>                    #clock-cells = <1>; >>>>>                }; >>>>> +            clkc_periphs: clock-controller { >>>>> +                compatible = "amlogic,s4-peripherals-clkc"; >>>>> +                reg = <0x0 0x0 0x0 0x49c>; >>>> >>>> This is broken... did you check for warnings? >>> >>> This is actually fine, the parent node has a ranges property: >>> https://github.com/torvalds/linux/blob/eb7081409f94a9a8608593d0fb63a1aa3d6f95d8/arch/arm64/boot/dts/amlogic/meson-s4.dtsi#L93 >>> >> >> The parent ranges do not change here anything. You cannot have a reg >> without unit address and the tools report it. No need to use reviewers >> for this... > > Oh I see now, I simply looked at the reg property, not the unit address. > > Sorry indeed it's wrong and DTC should complain. > > Yu, you should probably update your DTC version. Okay. > > Neil > >> >> Best regards, >> Krzysztof >> > > .