From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A28EC433F5 for ; Wed, 15 Sep 2021 08:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7A6E61244 for ; Wed, 15 Sep 2021 08:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237145AbhIOJBA (ORCPT ); Wed, 15 Sep 2021 05:01:00 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:54296 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237165AbhIOJAy (ORCPT ); Wed, 15 Sep 2021 05:00:54 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 577CF3FDC7 for ; Wed, 15 Sep 2021 08:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631696368; bh=39NyD7eSdjWRLG7akJoaBQq2vkbMMaThM/SwbRfMg/Y=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=DMiwzSqYW3AUg3oJEXVZANFWDVp5furaICTstN6E6aPxWTXiynPcTRYl+PlGbzCFl 1u3fluTHY/KZlAN+pBly5G9jQ1Jn18g7jdC+Lo4NHhqAcay7AF17xnsP7+7QRWyIXS 0Xi4aQ2MXD0qPp4SeQCkYWznJq1+oA3x/R0tGas8MxsUM+98sieIXijXYCZJ3/Q+my aK/RvX1ZgETnxy8VVo1PESmp9N8S7Zg4MDCiOyWannL8P7RlbzspNaE5OPOBJq20B+ sO3QRWI/lqTIRQ+l6KkF1mi9aaEcvuwppF4e3jCpPrukF2ir5dw1ce/6h6N+96mnMT L0ItJ4P5xw+3Q== Received: by mail-ej1-f72.google.com with SMTP id bx10-20020a170906a1ca00b005c341820edeso1147599ejb.10 for ; Wed, 15 Sep 2021 01:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=39NyD7eSdjWRLG7akJoaBQq2vkbMMaThM/SwbRfMg/Y=; b=jRqRlbEN5qa7lO+y5rbwxXsMZ2BxGauamG0IQWVDdrByN5QUE4Y+bMjWMASNWbEgjs eHCLZbh+8pUJnd/8cRKMwzY4BruhPrplB4W2TxN8ZVieI7AKunPq2QqjXNRIXE0oku5p AiEDzHaPLF7enbqeZFHsN7lxMrn5TGKEt2dIA9Zr8/WTdY8rwSlpO6MqrvYQw41nvxX3 ZjFMzjqiPCPFhFjeVG9AXboCbDDpm+UcRwVM1f316P8uuekSsK/E6i3R0yBJE/G0NpYh kkRWaUW1HuMt8qWQO8esGsMsVrMxIHzuP5vuC08vbCegQipeykKyXf13UCA+A8tjRGM0 8KSg== X-Gm-Message-State: AOAM530MDA4U62N90UdG5v069FjsCVYaAA5ftgXlHeQvY2W4NFijqQlf fplSF7iDJyVPYpXQ1AYP3pgzYfpTYwkeEezrj2i7zzBjQojUx6FNXrK/ahgKWODU4byMFiED3as JEXGBGoPWKxlg+wonI3YwaccHrlW3gIQz0BAp/w== X-Received: by 2002:a17:906:f15:: with SMTP id z21mr23428826eji.177.1631696368016; Wed, 15 Sep 2021 01:59:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymRnBWWR852OpGubXgrdOU89q9lNXSyAJz+ZILaji+sCwYZwgAvCN0PKGDsBRUEBEUCnD23A== X-Received: by 2002:a17:906:f15:: with SMTP id z21mr23428808eji.177.1631696367855; Wed, 15 Sep 2021 01:59:27 -0700 (PDT) Received: from [192.168.3.211] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id f24sm6703253edc.40.2021.09.15.01.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 01:59:27 -0700 (PDT) To: Sam Protsenko , Sylwester Nawrocki , =?UTF-8?Q?Pawe=c5=82_Chmiel?= , Chanwoo Choi , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette Cc: Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20210914155607.14122-1-semen.protsenko@linaro.org> <20210914155607.14122-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Subject: Re: [PATCH 6/6] clk: samsung: Introduce Exynos850 clock driver Message-ID: <3da75dbe-2f98-39db-c455-46adead7097b@canonical.com> Date: Wed, 15 Sep 2021 10:59:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210914155607.14122-7-semen.protsenko@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 14/09/2021 17:56, Sam Protsenko wrote: > This is the initial implementation adding only basic clocks like UART, > MMC, I2C and corresponding parent clocks. Design is influenced by > Exynos7 and Exynos5433 clock drivers. > > Signed-off-by: Sam Protsenko > --- > drivers/clk/samsung/Makefile | 1 + > drivers/clk/samsung/clk-exynos850.c | 700 ++++++++++++++++++++++++++++ > 2 files changed, 701 insertions(+) > create mode 100644 drivers/clk/samsung/clk-exynos850.c > > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 028b2e27a37e..c46cf11e4d0b 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -17,6 +17,7 @@ obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o > obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o > obj-$(CONFIG_EXYNOS_CLKOUT) += clk-exynos-clkout.o > obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o > +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos850.o > obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o > obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o > obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o > diff --git a/drivers/clk/samsung/clk-exynos850.c b/drivers/clk/samsung/clk-exynos850.c > new file mode 100644 > index 000000000000..1028caa2102e > --- /dev/null > +++ b/drivers/clk/samsung/clk-exynos850.c > @@ -0,0 +1,700 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2021 Linaro Ltd. > + * Author: Sam Protsenko > + * > + * Common Clock Framework support for Exynos850 SoC. > + */ > + > +#include > +#include > +#include > + > +#include > + > +#include "clk.h" > + > +/* Gate register bits */ > +#define GATE_MANUAL BIT(20) > +#define GATE_ENABLE_HWACG BIT(28) > + > +/* Gate register offsets range */ > +#define GATE_OFF_START 0x2000 > +#define GATE_OFF_END 0x2fff > + > +/** > + * exynos850_init_clocks - Set clocks initial configuration > + * @np: CMU device tree node with "reg" property (CMU addr) > + * @reg_offs: Register offsets array for clocks to init > + * @reg_offs_len: Number of register offsets in reg_offs array > + * > + * Set manual control mode for all gate clocks. > + */ > +static void __init exynos850_init_clocks(struct device_node *np, > + const unsigned long *reg_offs, size_t reg_offs_len) > +{ > + const __be32 *regaddr_p; > + u64 regaddr; > + u32 base; > + size_t i; > + > + /* Get the base address ("reg" property in dts) */ > + regaddr_p = of_get_address(np, 0, NULL, NULL); > + if (!regaddr_p) > + panic("%s: failed to get reg regaddr\n", __func__); > + > + regaddr = of_translate_address(np, regaddr_p); > + if (regaddr == OF_BAD_ADDR || !regaddr) > + panic("%s: bad reg regaddr\n", __func__); > + > + base = (u32)regaddr; > + > + for (i = 0; i < reg_offs_len; ++i) { > + void __iomem *reg; > + u32 val; > + > + /* Modify only gate clock registers */ > + if (reg_offs[i] < GATE_OFF_START || reg_offs[i] > GATE_OFF_END) > + continue; > + > + reg = ioremap(base + reg_offs[i], 4); You first translate the address to CPU physical address and then apply offset. This should be equivalent to one of_iomap() of entire range and iterate starting from the base pointer. IOW, I don't get why you have to map each register instead of mapping entire SFR/IO range? > + val = ioread32(reg); > + val |= GATE_MANUAL; > + val &= ~GATE_ENABLE_HWACG; > + iowrite32(val, reg); All other drivers use readl/writel, so how about keeping it consistent? Rest looks good but I did not verify the numbers :) Best regards, Krzysztof