From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Chan, Genevieve" <genevieve.chan@altera.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux driver reviews <linux-drivers-review@altera.com>
Subject: Re: [PATCH] dt-bindings: clock: agilex: mark mpu_l2ram_clk deprecated
Date: Thu, 6 Aug 2026 09:58:09 +0200 [thread overview]
Message-ID: <3daf5a61-c6ab-4e89-b74e-7f9bfc751c45@kernel.org> (raw)
In-Reply-To: <6fc29749-67ff-4754-91ee-4f8021d76254@altera.com>
On 06/08/2026 09:43, Chan, Genevieve wrote:
>>> +/* 42 - reserved/unused */
>>
>> How IDs can be reserved? These are implemented by drivers (abstract IDs
>> not used by hardware), so how driver could reserve it?
>>
>> Best regards,
>> Krzysztof
>>
> You are right. These IDs are DT clock specifier indices (provider one-cell ABI), not hardware IDs. The clk driver registers clocks into hws[id]; unused indices remain -ENOENT.
>
> ID 42 was never defined in the original Agilex binding (EMAC0=41, EMAC1=43). The comment was placed to only documents that historical hole so we do not renumber later IDs. It is not a hardware reservation — it is for ABI hygiene.
>
> Happy to reword to something clearer, e.g. /* 42 never assigned; do not renumber */, or drop the comment if preferred.
>
Please wrap your responses.
Comment is simply not needed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-06 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 9:49 [PATCH] dt-bindings: clock: agilex: mark mpu_l2ram_clk deprecated genevieve.chan
2026-08-04 7:49 ` Krzysztof Kozlowski
2026-08-06 7:43 ` Chan, Genevieve
2026-08-06 7:58 ` Krzysztof Kozlowski [this message]
2026-08-06 9:58 ` Krzysztof Kozlowski
2026-08-07 4:03 ` Chan, Genevieve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3daf5a61-c6ab-4e89-b74e-7f9bfc751c45@kernel.org \
--to=krzk@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=genevieve.chan@altera.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-drivers-review@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox