From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailoutvs13.siol.net ([185.57.226.204]:41313 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932723AbeF0U1G (ORCPT ); Wed, 27 Jun 2018 16:27:06 -0400 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Cc: wens@csie.org, robh+dt@kernel.org, airlied@linux.ie, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, seanpaul@chromium.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 00/24] Add support for R40 HDMI pipeline Date: Wed, 27 Jun 2018 22:25:37 +0200 Message-ID: <4275695.oLYl8XEDF6@jernej-laptop> In-Reply-To: <20180627195043.hfasvppfm2cbudx7@flea> References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180627180215.y5kvvdqeriadxwte@flea> <20180627195043.hfasvppfm2cbudx7@flea> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-clk-owner@vger.kernel.org List-ID: Dne sreda, 27. junij 2018 ob 21:50:43 CEST je Maxime Ripard napisal(a): > 1;5202;0c > > On Wed, Jun 27, 2018 at 08:02:15PM +0200, Maxime Ripard wrote: > > On Mon, Jun 25, 2018 at 02:02:40PM +0200, Jernej Skrabec wrote: > > > This series adds support for R40 HDMI pipeline. It is a bit special > > > than other already supported pipelines because it has additional unit > > > called TCON TOP responsible for relationship configuration between > > > mixers, TCONs and HDMI. Additionally, it has additional gates for DSI > > > and TV TCONs, TV encoder clock settings and pin muxing between LCD > > > and TV encoders. > > > > > > However, it seems that TCON TOP will become a norm, since newer > > > Allwinner SoCs like H6 also have this unit. > > > > > > I tested different possible configurations: > > > - mixer0 <> TCON-TV0 <> HDMI > > > - mixer0 <> TCON-TV1 <> HDMI > > > - mixer1 <> TCON-TV0 <> HDMI > > > - mixer1 <> TCON-TV1 <> HDMI > > > > > > Please review. > > > > I just applied it. It didn't apply cleanly, so please make sure it > > does next time, or at least state what the dependencies are. > > And it didn't compile either, because of the compile error that was > reported to the previous version by kbuild... Those shouldn't be > ignored and simply fixed. Sorry about that. I forgot to rebase and had same linux-next base for all 3 versions. I actually take a look at that kbuild message, but it just didn't make much sense and it worked for me without issues. Merge conflicts would explain that. Best regards, Jernej