Re: [PATCH 03/16] clk: qcom: smd-rpm: remove duplication between qcs404 and qcm2290 clocks

Dmitry Baryshkov
2022-12-06T23:19:05Z

On 05/12/2022 19:04, Alex Elder wrote:
> On 12/3/22 11:57 AM, Dmitry Baryshkov wrote:
>> Reuse qcs404's QPIC and BIMC_GPU clock for qcm2290.
>>
>> Fixes: 78b727d02815 ("clk: qcom: smd-rpm: Add QCM2290 RPM clock support")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> I'm not going to comment on the "Fixes" tag on this or any of the
> later patches in this series.
>
> Shouldn't this line be removed too?
>
> DEFINE_CLK_SMD_RPM(qcm2290, bimc_gpu_clk, bimc_gpu_a_clk,
>                    QCOM_SMD_RPM_MEM_CLK, 2);

Nice catch, I'll drop it.

>
>                     -Alex
>

--
With best wishes
Dmitry