Re: [PATCH 02/16] clk: qcom: smd-rpm: enable pin-controlled ln_bb_clk clocks on qcs404

Alex Elder
2022-12-05T17:04:29Z

On 12/3/22 11:57 AM, Dmitry Baryshkov wrote:
> The commit eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm
> clocks") defined the pin-controlled ln_bb_clk clocks, but didn't add
> them to the qcs404_clks array. Add them to make these clocks usable to
> platform devices.

This *sounds* like a bug fix, but I think the clocks--although
defined--have been unused to date. So maybe not a bug?

Nice that you found this missing code though.

Aside from the "back-port or not" question, this looks good.

Reviewed-by: Alex Elder <elder@linaro.org?

>
> Fixes: eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/qcom/clk-smd-rpm.c | 2 ++
> include/dt-bindings/clock/qcom,rpmcc.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index 077875cf0d80..877ffda42ee9 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -843,6 +843,8 @@ static struct clk_smd_rpm *qcs404_clks[] = {
> [RPM_SMD_RF_CLK1_A] = &msm8916_rf_clk1_a,
> [RPM_SMD_LN_BB_CLK] = &msm8992_ln_bb_clk,
> [RPM_SMD_LN_BB_A_CLK] = &msm8992_ln_bb_a_clk,
> + [RPM_SMD_LN_BB_CLK_PIN] = &qcs404_ln_bb_clk_pin,
> + [RPM_SMD_LN_BB_A_CLK_PIN] = &qcs404_ln_bb_clk_a_pin,
> };
>
> static const struct rpm_smd_clk_desc rpm_clk_qcs404 = {
> diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h
> index c0ad624e930e..46309c9953b2 100644
> --- a/include/dt-bindings/clock/qcom,rpmcc.h
> +++ b/include/dt-bindings/clock/qcom,rpmcc.h
> @@ -168,5 +168,7 @@
> #define RPM_SMD_MSS_CFG_AHB_CLK 122
> #define RPM_SMD_MSS_CFG_AHB_A_CLK 123
> #define RPM_SMD_BIMC_FREQ_LOG 124
> +#define RPM_SMD_LN_BB_CLK_PIN 125
> +#define RPM_SMD_LN_BB_A_CLK_PIN 126
>
> #endif