From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573CE383A5; Sun, 21 Apr 2024 18:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713723278; cv=none; b=EZdoIVjlgTIwSnUoQV3n3xoGjIERZoicl3MM3puYR65onPalHTOOUx5DiRqartLkxkLpZ7XXkmrbzv+isV/AOVJxUUhg3Ssg8gjL6Z5GxABetG2eOwlHm0yIV1k5yyChyuJ4xjbjmEcKDq4C8PjTDcHIegMf8tjGafryrcVqcZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713723278; c=relaxed/simple; bh=NZPIJ6LLpCZyFzBCf6T3HzpkPCMGo9MmvGw9KeZNOXQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qA5sv7GfGIuTM+neWYu2ieY6GyZru7Qg4B7YCzRuvI0PzESvLMqK3DObprEN45LA7ZUCrhKE+L3TkIZe9uBVLgYdpmN06LR+hEEyj8bdA0VZCRZ5Ujnvp0TS7dbeKGBE5+I5qIvoWFiettJ9lpzPetbopw86JLoW0LmLT10vZtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EbSmLXIM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EbSmLXIM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB83BC113CE; Sun, 21 Apr 2024 18:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713723277; bh=NZPIJ6LLpCZyFzBCf6T3HzpkPCMGo9MmvGw9KeZNOXQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EbSmLXIMifLYsMbNn3RR9C73zMefvlh9w47fHrXdsYI6DAIQhm9RjpbyFF/qOEJFn 1HZCX/Tei7NBOdJ3xyt8ds6WnYVdIwZwWtDhQ65x++OtOQRASwXQ5XFHkOqvSyoL5V ZALLaKfGrqYRCId53LUCXV78Xd0l3XyNtxmzAguNN8tlyfrPPPKuJblQB2iOQF2Mm1 7ENuq4AHnC5oGxXxXeAJs8ovvTxoUTBELJIlbLyAu+llUXjy77/UP60LOXA+nFceAl C5EMvphIMqA54TiP8NxwWgVQKOnZvKV3ncCdyKqvFWf+IldZw/piEIjIRaxBeWIFNK oCFzsQGtiuhuw== Message-ID: <48e9f035-390b-40c9-a3ad-49880c0b972d@kernel.org> Date: Sun, 21 Apr 2024 20:14:30 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 4/6] dt-bindings: clock: meson: document A1 SoC audio clock controller driver To: Jan Dakinevich , Rob Herring Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , Philipp Zabel , Jiucheng Xu , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240419125812.983409-1-jan.dakinevich@salutedevices.com> <20240419125812.983409-5-jan.dakinevich@salutedevices.com> <20240419210949.GA3979121-robh@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/04/2024 18:15, Jan Dakinevich wrote: > > > On 4/20/24 00:09, Rob Herring wrote: >> On Fri, Apr 19, 2024 at 03:58:10PM +0300, Jan Dakinevich wrote: >>> Add device tree bindings for A1 SoC audio clock and reset controllers. >>> >>> Signed-off-by: Jan Dakinevich >>> --- >>> >>> This controller has 6 mandatory and up to 20 optional clocks. To describe >>> this, I use 'additionalItems'. It produces correct processed-schema.json: >>> >>> "clock-names": { >>> "maxItems": 26, >>> "items": [ >>> { >>> "const": "pclk" >>> }, >>> { >>> "const": "dds_in" >>> }, >>> { >>> "const": "fclk_div2" >>> }, >>> { >>> "const": "fclk_div3" >>> }, >>> { >>> "const": "hifi_pll" >>> }, >>> { >>> "const": "xtal" >>> } >>> ], >>> "additionalItems": { >>> "oneOf": [ >>> { >>> "pattern": "^slv_sclk[0-9]$" >>> }, >>> { >>> "pattern": "^slv_lrclk[0-9]$" >>> } >>> ] >>> }, >>> "type": "array", >>> "minItems": 6 >>> }, >>> >>> and it behaves as expected. However, the checking is followed by >>> complaints like this: >>> >>> Documentation/devicetree/bindings/clock/amlogic,a1-audio-clkc.yaml: properties:clock-names:additionalItems: {'oneOf': [{'pattern': '^slv_sclk[0-9]$'}, {'pattern': '^slv_lrclk[0-9]$'}]} is not of type 'boolean' >>> >>> And indeed, 'additionalItems' has boolean type in meta-schema. So, how to >>> do it right? >> >> The meta-schemas are written both to prevent nonsense that json-schema >> allows by default (e.g additionalitems (wrong case)) and constraints to >> follow the patterns we expect. I'm happy to loosen the latter case if >> there's really a need. >> >> Generally, most bindings shouldn't be using 'additionalItems' at all as >> all entries should be defined, but there's a few exceptions. Here, the >> only reasoning I see is 26 entries is a lot to write out, but that >> wouldn't really justify it. > > Writing a lot of entries don't scary me too much, but the reason is that > the existence of optional clock sources depends on schematics. Also, we Aren't you documenting SoC component, not a board? So how exactly it depends on schematics? SoC is done or not done... > unable to declare dt-nodes for 'clocks' array in any generic way, > because their declaration would depends on that what is actually > connected to the SoC (dt-node could be "fixed-clock" with specific rate > or something else). So these are clock inputs to the SoC? > > By the way, I don't know any example (neither for A1 SoC nor for other > Amlogic's SoCs) where these optional clocks are used, but they are > allowed by hw. > > This is my understanding of this controller. I hope, Jerome Brunet will > clarify how it actually works. Best regards, Krzysztof