Linux clock framework development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Shengjiu Wang <shengjiu.wang@nxp.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kernel-janitors@vger.kernel.org, imx@lists.linux.dev,
	Abel Vesa <abelvesa@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Marek Vasut <marex@denx.de>,
	Michael Turquette <mturquette@baylibre.com>,
	Peng Fan <peng.fan@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel@pengutronix.de, Shengjiu Wang <shengjiu.wang@gmail.com>
Subject: Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller
Date: Sat, 25 May 2024 09:26:53 +0200	[thread overview]
Message-ID: <4c53b063-ad12-405d-b088-9b992284ba08@web.de> (raw)
In-Reply-To: <1716458390-20120-3-git-send-email-shengjiu.wang@nxp.com>

…
> The reset controller is supported by the auxiliary device
> framework.

Would you like to add an imperative wording for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
> +							 struct clk_imx8mp_audiomix_priv *priv)
> +{
> +	struct auxiliary_device __free(kfree) * adev = NULL;
> +	int ret;
> +
> +	adev = kzalloc(sizeof(*adev), GFP_KERNEL);
…

May the following source code variant be applied here?

	int ret;
	struct auxiliary_device __free(kfree) *adev = kzalloc(sizeof(*adev), GFP_KERNEL);


Regards,
Markus

  parent reply	other threads:[~2024-05-25  7:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23  9:59 [PATCH v5 0/5] clk: imx: clk-audiomix: Improvement for audiomix Shengjiu Wang
2024-05-23  9:59 ` [PATCH v5 1/5] dt-bindings: clock: imx8mp: Add #reset-cells property Shengjiu Wang
2024-05-23  9:59 ` [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller Shengjiu Wang
2024-05-23 20:36   ` Frank Li
2024-05-24  1:49     ` Shengjiu Wang
2024-05-27  8:01       ` Dan Carpenter
2024-05-25  7:26   ` Markus Elfring [this message]
2024-05-27  3:43     ` Shengjiu Wang
2024-05-23  9:59 ` [PATCH v5 3/5] reset: imx-aux: Add i.MX auxiliary reset driver Shengjiu Wang
2024-05-23  9:59 ` [PATCH v5 4/5] clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks Shengjiu Wang
2024-05-24  1:04   ` Peng Fan
2024-05-23  9:59 ` [PATCH v5 5/5] clk: imx: clk-audiomix: Corrent parent clock for earc_phy and audpll Shengjiu Wang
2024-05-24  1:05   ` Peng Fan
2024-05-25  7:55   ` Markus Elfring
2024-05-27  3:44     ` Shengjiu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c53b063-ad12-405d-b088-9b992284ba08@web.de \
    --to=markus.elfring@web.de \
    --cc=abelvesa@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox