From: "Arnd Bergmann" <arnd@arndb.de>
To: "Fabio Estevam" <festevam@gmail.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Martin Kaiser" <martin@kaiser.cx>
Cc: soc@kernel.org, "Russell King" <linux@armlinux.org.uk>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Hartley Sweeten" <hsweeten@visionengravers.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Viresh Kumar" <vireshk@kernel.org>,
"Shiraz Hashim" <shiraz.linux.kernel@gmail.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-clk@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision()
Date: Wed, 17 May 2023 08:39:53 +0200 [thread overview]
Message-ID: <4e026f08-d733-4b01-ab47-e921d041e74e@app.fastmail.com> (raw)
In-Reply-To: <CAOMZO5B0stW2X6YqPTTKDpCOAzPDvm=4HT8jfBAgbTy11gnKgg@mail.gmail.com>
On Wed, May 17, 2023, at 01:34, Fabio Estevam wrote:
> On Tue, May 16, 2023 at 12:32 PM Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This function has no prototype and no callers:
>>
>> arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Martin Kaiser sent a patch adding a user for this function:
>
> https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@kaiser.cx/
>
> It would be better to apply Martin's patch instead of removing mx25_revision().
I think either way is ok to address the warning. If we wanted to do this
properly, the mx{25,27,31,35,5}_revision functions could all be removed
and the logic hooked up to imx_set_soc_revision() in the same way that
they already use mxc_set_cpu_type() for drivers/soc/imx/soc-imx.c.
I'll leave it up to you, if you want to merge Martin's patches or
a replacement for the soc-imx driver through the imx tree for 6.5,
I'll drop my patch from this series, otherwise I'll keep it for now
and we can still do it better at later point.
Arnd
next prev parent reply other threads:[~2023-05-17 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230516153109.514251-1-arnd@kernel.org>
[not found] ` <20230516153109.514251-2-arnd@kernel.org>
2023-05-16 15:41 ` [PATCH 01/13] ARM: davinci: fix davinci_cpufreq_init() declaration Bartosz Golaszewski
[not found] ` <20230516153109.514251-3-arnd@kernel.org>
2023-05-16 15:51 ` [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings Alexander Sverdlin
[not found] ` <20230516153109.514251-4-arnd@kernel.org>
2023-05-16 15:58 ` [PATCH 03/13] ARM: highbank: add missing include Andre Przywara
[not found] ` <20230516153109.514251-10-arnd@kernel.org>
2023-05-16 16:17 ` [PATCH 09/13] ARM: orion5x: fix d2net gpio initialization Andrew Lunn
[not found] ` <20230516153109.514251-8-arnd@kernel.org>
2023-05-16 23:18 ` [PATCH 07/13] ARM: omap1: add missing include Aaro Koskinen
2023-05-17 5:58 ` Tony Lindgren
2023-05-17 5:58 ` Tony Lindgren
[not found] ` <20230516153109.514251-9-arnd@kernel.org>
2023-05-16 23:20 ` [PATCH 08/13] ARM: omap2: fix missing tick_broadcast() prototype Aaro Koskinen
[not found] ` <20230516153109.514251-6-arnd@kernel.org>
2023-05-16 23:34 ` [PATCH 05/13] ARM: imx: remove unused mx25_revision() Fabio Estevam
2023-05-17 6:39 ` Arnd Bergmann [this message]
2023-05-17 15:45 ` Martin Kaiser
2023-07-28 15:59 ` Arnd Bergmann
2023-07-30 16:26 ` Martin Kaiser
[not found] ` <20230516153109.514251-13-arnd@kernel.org>
2023-05-17 4:34 ` [PATCH 12/13] ARM: spear: include "pl080.h" for pl080_get_signal() prototype Viresh Kumar
[not found] ` <20230516153109.514251-7-arnd@kernel.org>
2023-05-23 20:17 ` [PATCH 06/13] ARM: lpc32xx: add missing include Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e026f08-d733-4b01-ab47-e921d041e74e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=aaro.koskinen@iki.fi \
--cc=alexander.sverdlin@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=daniel@zonque.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=martin@kaiser.cx \
--cc=mturquette@baylibre.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sudeep.holla@arm.com \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox