Re: [PATCH v4 6/6] arm64: dts: qcom: x1e80100: Add support for PCIe3 on x1e80100

Manivannan Sadhasivam
2024-09-25T07:59:03Z

On Wed, Sep 25, 2024 at 02:37:41PM +0800, Qiang Yu wrote:
>
> On 9/24/2024 10:43 PM, Johan Hovold wrote:
> > On Tue, Sep 24, 2024 at 03:14:44AM -0700, Qiang Yu wrote:
> > > Describe PCIe3 controller and PHY. Also add required system resources like
> > > regulators, clocks, interrupts and registers configuration for PCIe3.
> > > @@ -2907,6 +2907,208 @@ mmss_noc: interconnect@1780000 {
> > > #interconnect-cells = <2>;
> > > };
> > > + pcie3: pcie@1bd0000 {
> > > + device_type = "pci";
> > > + compatible = "qcom,pcie-x1e80100";
> > > + interrupts = <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 769 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 836 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 671 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>;
> > > + interrupt-names = "msi0",
> > > + "msi1",
> > > + "msi2",
> > > + "msi3",
> > > + "msi4",
> > > + "msi5",
> > > + "msi6",
> > > + "msi7",
> > > + "global";
> > This ninth "global" interrupt is not described by the bindings, which
> > would also need to be updated. What is it used for?
>
> As of now, the global interrupts is mainly used to get link up event so
> that the device driver can enumerate the PCIe endpoint devices without
> user intervention. You can refer to
> https://lore.kernel.org/linux-pci/20240828-pci-qcom-hotplug-v4-11-263a385fbbcb@linaro.org.
>
> I see this global interrupts has been documented in qcom,pcie-sm8450.yaml.
> Do I need to move it to qcom,pcie-common.yaml?
>

No, you need to describe it in qcom,pcie-x1e80100.yaml.

- Mani

--
மணிவண்ணன் சதாசிவம்