Re: [PATCH v4 6/6] arm64: dts: qcom: x1e80100: Add support for PCIe3 on x1e80100

Qiang Yu
2024-09-25T03:57:27Z

On 9/24/2024 10:26 PM, Konrad Dybcio wrote:
> On 24.09.2024 12:14 PM, Qiang Yu wrote:
>> Describe PCIe3 controller and PHY. Also add required system resources like
>> regulators, clocks, interrupts and registers configuration for PCIe3.
>>
>> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
> Qiang, Mani
>
> I have a RTS5261 mmc chip on PCIe3 on the Surface Laptop.
> Adding the global irq breaks sdcard detection (the chip still comes
> up fine) somehow. Removing the irq makes it work again :|
>
> I've confirmed that the irq number is correct
Actually, I verified this patch with several devices (SDX75, AIC100 and
R8169 of TP-LINK) attached to X1E80100 QCP. But I didn't meet this issue.
Each device was detected. Can you please share boot log if it is possible?

Mani, did you ever meet similar issue on other platforms?

0003:01:00.0 Class 0200: Device 10ec:8161 (rev 15)
Subsystem: Device 10ec:8168
I/O ports at 100000 [size=256]
Memory at 78304000 (64-bit, non-prefetchable) [size=4K]
Memory at 78300000 (64-bit, non-prefetchable) [size=16K]
Kernel driver in use: r8169

0003:01:00.0 Class ff00: Device 17cb:0309
Subsystem: Device 17cb:0309
Memory at 78580000 (64-bit, non-prefetchable) [size=4K]
Memory at 78581000 (64-bit, non-prefetchable) [size=4K]
Kernel driver in use: mhi-pci-generic

0003:01:00.0 Class 1200: Device 17cb:a100
Subsystem: Device 17cb:a100
Region 0: Memory at 78300000 (64-bit, non-prefetchable)
[disabled] [size=4K]
Region 2: Memory at 78400000 (64-bit, non-prefetchable)
[disabled] [size=2M]
Region 4: Memory at 78600000 (64-bit, prefetchable) [disabled]
[size=64K]

Thanks,
Qiang Yu
>
> Konrad