From: Marek Vasut <marex@denx.de>
To: "Sagar, Vishal" <vishal.sagar@amd.com>, linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Michal Simek <michal.simek@amd.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org, parth.gajjar@amd.com,
"Allagadapa, Varunkumar" <varunkumar.allagadapa@amd.com>
Subject: Re: [PATCH] clk: zynqmp: Work around broken DT GPU node
Date: Mon, 11 Nov 2024 17:25:27 +0100 [thread overview]
Message-ID: <4ee8d8a5-ec00-4b11-a7bc-4137e1982218@denx.de> (raw)
In-Reply-To: <dd4cb501-5fc7-4430-9ffc-9c8c910df425@amd.com>
On 11/11/24 3:33 PM, Sagar, Vishal wrote:
> Hi Marek,
>
> Thanks for sharing this patch.
>
> On 10/31/2024 5:59 PM, Marek Vasut wrote:
>> The ZynqMP DT GPU node clock description is wrong and does not represent
>> the hardware correctly, it only describes BUS and PP0 clock, while it is
>> missing PP1 clock. That means PP1 clock can never be enabled when the GPU
>> should be used, which leads to expected GPU hang even with simple basic
>> tests like kmscube.
>
> Could you please share how you tested this?
I tested this by running kmscube, see one line above.
> Please share the dt node too.
The GPU DT node is already in arch/arm64/boot/dts/xilinx/zynqmp.dtsi .
> We will also check at our end and revert for this.
I do not understand this statement . Revert what ?
next prev parent reply other threads:[~2024-11-11 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 16:59 [PATCH] clk: zynqmp: Work around broken DT GPU node Marek Vasut
2024-11-11 14:33 ` Sagar, Vishal
2024-11-11 16:25 ` Marek Vasut [this message]
2024-11-12 13:17 ` Gajjar, Parth
2024-11-12 20:00 ` Marek Vasut
2024-11-13 13:32 ` Gajjar, Parth
2024-11-13 19:55 ` Marek Vasut
2024-11-26 5:25 ` Gajjar, Parth
2024-11-26 16:18 ` Marek Vasut
2024-11-28 14:35 ` Gajjar, Parth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee8d8a5-ec00-4b11-a7bc-4137e1982218@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=parth.gajjar@amd.com \
--cc=sboyd@kernel.org \
--cc=varunkumar.allagadapa@amd.com \
--cc=vishal.sagar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox