From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: reset Add AST2700 reset bindings
Date: Fri, 9 Aug 2024 08:07:23 +0200 [thread overview]
Message-ID: <4f1c275d-63bd-4649-9517-17ac4f20e3bf@kernel.org> (raw)
In-Reply-To: <OS8PR06MB7541E0944EAD547DED2AE561F2BA2@OS8PR06MB7541.apcprd06.prod.outlook.com>
On 09/08/2024 07:42, Ryan Chen wrote:
>>> +#define SCU0_RESET_PORTA_EHCI (38)
>>> +#define SCU0_RESET_PORTA_VHUB0 (38)
>>
>> Is having 38 twice expected?
>> If not, why not use an enum, BTW?
>>
> Yes, it is expected. Due to 38 is shared reset for 2 usb controller.
> One for EHCI, another is for vhub0. So I do define the same value.
> That I can do more clear in dtsi description.
> The following will be expected dtsi file descript.
No, that's confusing. Don't do this. You are hiding information that one
reset is shared. Terrible idea.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-09 6:07 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 7:59 [PATCH 0/4] Add support for AST2700 clk driver Ryan Chen
2024-08-08 7:59 ` [PATCH 1/4] dt-bindings: mfd: aspeed: support for AST2700 Ryan Chen
2024-08-08 10:14 ` Krzysztof Kozlowski
2024-08-09 5:55 ` Ryan Chen
2024-08-09 6:02 ` Krzysztof Kozlowski
2024-08-09 6:10 ` Ryan Chen
2024-08-12 6:26 ` Ryan Chen
2024-08-12 6:34 ` Krzysztof Kozlowski
2024-08-13 19:14 ` Rob Herring
2024-08-14 6:35 ` Ryan Chen
2024-08-15 0:26 ` Andrew Jeffery
2024-08-15 1:43 ` Ryan Chen
2024-08-15 1:56 ` Andrew Jeffery
2024-08-19 3:05 ` Ryan Chen
2024-08-20 0:46 ` Andrew Jeffery
2024-08-20 1:52 ` Ryan Chen
2024-08-20 5:01 ` Andrew Jeffery
2024-08-20 6:51 ` Ryan Chen
2024-08-08 7:59 ` [PATCH 2/4] dt-bindings: reset Add AST2700 reset bindings Ryan Chen
2024-08-08 8:35 ` Christophe JAILLET
2024-08-09 5:42 ` Ryan Chen
2024-08-09 6:07 ` Krzysztof Kozlowski [this message]
2024-08-09 6:12 ` Ryan Chen
2024-08-08 10:16 ` Krzysztof Kozlowski
2024-08-09 6:06 ` Ryan Chen
2024-08-09 6:08 ` Krzysztof Kozlowski
2024-08-08 7:59 ` [PATCH 3/4] dt-bindings: clock: Add AST2700 clock bindings Ryan Chen
2024-08-08 8:39 ` Christophe JAILLET
2024-08-09 5:47 ` Ryan Chen
2024-08-09 6:06 ` Krzysztof Kozlowski
2024-08-09 6:25 ` Ryan Chen
2024-08-09 7:31 ` Krzysztof Kozlowski
2024-08-12 7:26 ` Ryan Chen
2024-08-12 8:16 ` Krzysztof Kozlowski
2024-08-12 8:22 ` Ryan Chen
2024-08-12 8:30 ` Krzysztof Kozlowski
2024-08-12 8:54 ` Ryan Chen
2024-08-12 9:39 ` Ryan Chen
2024-08-12 9:54 ` Krzysztof Kozlowski
2024-08-13 1:53 ` Ryan Chen
2024-08-13 5:55 ` Krzysztof Kozlowski
2024-08-19 5:55 ` Ryan Chen
2024-08-19 6:01 ` Krzysztof Kozlowski
2024-08-19 6:42 ` Ryan Chen
2024-08-19 8:45 ` Krzysztof Kozlowski
2024-08-19 9:31 ` Ryan Chen
2024-08-08 10:17 ` Krzysztof Kozlowski
2024-08-08 7:59 ` [PATCH 4/4] " Ryan Chen
2024-08-08 10:18 ` Krzysztof Kozlowski
2024-08-19 5:57 ` Ryan Chen
2024-08-19 6:01 ` Krzysztof Kozlowski
2024-08-19 7:12 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f1c275d-63bd-4649-9517-17ac4f20e3bf@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox