Re: [PATCH v6 2/5] dt-bindings: clock: add Amlogic T7 SCMI clock controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/12/2025 09:40, Jian Hu wrote:
> Hi, Krzysztof
> 
> 
> Thans for your review.
> 
> On 12/8/2025 2:17 PM, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On Thu, Dec 04, 2025 at 01:36:31PM +0800, Jian Hu wrote:
>>> Add DT bindings for the SCMI clock controller of the Amlogic T7 SoC family.
>>>
>>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>>   include/dt-bindings/clock/amlogic,t7-scmi.h | 47 +++++++++++++++++++++
>>>   1 file changed, 47 insertions(+)
>>>   create mode 100644 include/dt-bindings/clock/amlogic,t7-scmi.h
>>>
>> Where is any binding doc for this? Why is this a separate patch?
> 
> 
> The ARM SCMI device tree binding specification is located at 
> ./Documentation/devicetree/bindings/firmware/arm,scmi.yaml.

Then git grep for the file name - there is no such compatible. Are you
sure you follow writing bindings doc?

Think how are you going to use these values. You will have phandle, yes?
To some controller, yes? Which one?

> 
> Certain secure clocks on the T7 rely on the ARM SCMI driver stack, which 
> is officially supported by ARM.
> 
> The kernel-side SCMI client implementation resides in 
> ./drivers/firmware/arm_scmi/.
> 
> To enable ARM SCMI on T7, three components are needed:
> 
> - Kernel-side definition of ARM SCMI clock indices (this patch addresses 
> this component);
> - SCMI server implementation in the ARM Trusted Firmware (ATF) running 
> at Exception Level 3 (EL3), which has been integrated into the bootloader;
> - Device Tree Source (DTS) configuration for ARM SCMI clock nodes (the 
> DTS changes will be submitted after the T7 clock driver patches are 
> merged upstream).

So silently you keep the users hidden? No, I want to see the users.


Best regards,
Krzysztof