Re: [PATCH 0/7] clk: qcom: gcc: Do not turn off PCIe GDSCs during gdsc_disable()

Konrad Dybcio
2026-01-30T10:36:16Z

On 1/2/26 10:43 AM, Krishna Chaitanya Chundru wrote:
> With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This
> can happen during scenarios such as system suspend and breaks the resume
> of PCIe controllers from suspend.
>
> So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs
> during gdsc_disable() and allow the hardware to transition the GDSCs to
> retention when the parent domain enters low power state during system
> suspend.
>
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> ---
> Krishna Chaitanya Chundru (7):
> clk: qcom: gcc-sc7280: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-sa8775p: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-sm8750: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-glymur: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-qcs8300: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-x1e80100: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-kaanapali: Do not turn off PCIe GDSCs during gdsc_disable()
>
> drivers/clk/qcom/gcc-glymur.c | 16 ++++++++--------
> drivers/clk/qcom/gcc-kaanapali.c | 2 +-
> drivers/clk/qcom/gcc-qcs8300.c | 4 ++--
> drivers/clk/qcom/gcc-sa8775p.c | 4 ++--
> drivers/clk/qcom/gcc-sc7280.c | 2 +-
> drivers/clk/qcom/gcc-sm8750.c | 2 +-
> drivers/clk/qcom/gcc-x1e80100.c | 16 ++++++++--------
> 7 files changed, 23 insertions(+), 23 deletions(-)

Using a terrible chain of shell commands:

rg "pcie.*_gdsc " -A 8 drivers/clk/qcom | grep OFF | awk '{print $1}' | sort | uniq

I get a larger list (it may be incomplete):

drivers/clk/qcom/gcc-apq8084.c-
drivers/clk/qcom/gcc-glymur.c-
drivers/clk/qcom/gcc-msm8994.c-
drivers/clk/qcom/gcc-msm8996.c-
drivers/clk/qcom/gcc-msm8998.c-
drivers/clk/qcom/gcc-qcs615.c-
drivers/clk/qcom/gcc-qdu1000.c-
drivers/clk/qcom/gcc-sar2130p.c-
drivers/clk/qcom/gcc-sc7280.c-
drivers/clk/qcom/gcc-sc8180x.c-
drivers/clk/qcom/gcc-sc8280xp.c-
drivers/clk/qcom/gcc-sdm660.c-
drivers/clk/qcom/gcc-sdm845.c-
drivers/clk/qcom/gcc-sdx55.c-
drivers/clk/qcom/gcc-sdx65.c-
drivers/clk/qcom/gcc-sdx75.c-
drivers/clk/qcom/gcc-sm4450.c-
drivers/clk/qcom/gcc-sm7150.c-
drivers/clk/qcom/gcc-sm8150.c-
drivers/clk/qcom/gcc-sm8350.c-
drivers/clk/qcom/gcc-x1e80100.c-

I presume these changes should apply to all of them?

(sidenote: 660 has a PCIe GDSC even though it doesn't have PCIe.. nice)

Konrad