Re: [PATCH 0/7] clk: qcom: gcc: Do not turn off PCIe GDSCs during gdsc_disable()

Manivannan Sadhasivam
2026-01-05T05:15:42Z

On Fri, Jan 02, 2026 at 03:13:00PM +0530, Krishna Chaitanya Chundru wrote:
> With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This
> can happen during scenarios such as system suspend and breaks the resume
> of PCIe controllers from suspend.
>
> So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs
> during gdsc_disable() and allow the hardware to transition the GDSCs to
> retention when the parent domain enters low power state during system
> suspend.
>
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
> Krishna Chaitanya Chundru (7):
> clk: qcom: gcc-sc7280: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-sa8775p: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-sm8750: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-glymur: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-qcs8300: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-x1e80100: Do not turn off PCIe GDSCs during gdsc_disable()
> clk: qcom: gcc-kaanapali: Do not turn off PCIe GDSCs during gdsc_disable()
>
> drivers/clk/qcom/gcc-glymur.c | 16 ++++++++--------
> drivers/clk/qcom/gcc-kaanapali.c | 2 +-
> drivers/clk/qcom/gcc-qcs8300.c | 4 ++--
> drivers/clk/qcom/gcc-sa8775p.c | 4 ++--
> drivers/clk/qcom/gcc-sc7280.c | 2 +-
> drivers/clk/qcom/gcc-sm8750.c | 2 +-
> drivers/clk/qcom/gcc-x1e80100.c | 16 ++++++++--------
> 7 files changed, 23 insertions(+), 23 deletions(-)
> ---
> base-commit: 98e506ee7d10390b527aeddee7bbeaf667129646
> change-id: 20260102-pci_gdsc_fix-1dcf08223922
>
> Best regards,
> --
> Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
>

--
மணிவண்ணன் சதாசிவம்