From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v8 42/42] ARM: dts: da850: Add clocks To: Sekhar Nori , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , Bartosz Golaszewski , Adam Ford , linux-kernel@vger.kernel.org References: <1521168778-27236-1-git-send-email-david@lechnology.com> <1521168778-27236-43-git-send-email-david@lechnology.com> <510309d2-2df0-a915-a6f6-082b41c6b28b@ti.com> From: David Lechner Message-ID: <5502d0ee-b5dc-e90a-a041-882350c7d339@lechnology.com> Date: Mon, 2 Apr 2018 11:15:09 -0500 MIME-Version: 1.0 In-Reply-To: <510309d2-2df0-a915-a6f6-082b41c6b28b@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 04/02/2018 06:12 AM, Sekhar Nori wrote: > On Friday 16 March 2018 10:50 PM, David Lechner wrote: >> On 03/15/2018 09:52 PM, David Lechner wrote: >>> This adds clock provider nodes for da850 and wires them up to all of the >>> devices. >>> >>> Signed-off-by: David Lechner >>> --- >> >> ... >> >> This is the mcasp0: mcasp@100000 node... >> >>> @@ -560,6 +720,7 @@ >>>               dmas = <&edma0 1 1>, >>>                   <&edma0 0 1>; >>>               dma-names = "tx", "rx"; >>> +            clocks = <&psc1 7>; >> >> After some testing, it looks like it needs to be: >> >> +            power-domains = <&psc1 7>; >> >> instead of >> >> +            clocks = <&psc1 7>; > > We should probably have both clocks and power-domains properties for all > PSC clocks. This way, the driver can change without a corresponding DT > update dependency. > > Thanks, > Sekhar > That's fine with me. I just didn't know how people felt about using properties that are not documented.