Re: [PATCH 3/6] clk: keystone: make use of of_clk_parent_fill helper function

[santosh shilimkar <santosh.shilimkar@oracle.com>]

On 6/10/2015 2:49 PM, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Use of_clk_parent_fill to fill in the parent clock names' array.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> ---
>   drivers/clk/keystone/pll.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
Looks fine by me.
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>


> diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c
> index 0dd8a4b..d885372 100644
> --- a/drivers/clk/keystone/pll.c
> +++ b/drivers/clk/keystone/pll.c
> @@ -293,8 +293,7 @@ static void __init of_pll_mux_clk_init(struct device_node *node)
>   		return;
>   	}
>
> -	parents[0] = of_clk_get_parent_name(node, 0);
> -	parents[1] = of_clk_get_parent_name(node, 1);
> +	of_clk_parent_fill(node, parents, 2);
>   	if (!parents[0] || !parents[1]) {
>   		pr_err("%s: missing parent clocks\n", __func__);
>   		return;
>