From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5578B6C3.50106@oracle.com> Date: Wed, 10 Jun 2015 15:14:27 -0700 From: santosh shilimkar MIME-Version: 1.0 To: dinguyen@opensource.altera.com, sboyd@codeaurora.org, mturquette@linaro.org CC: dinh.linux@gmail.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Santosh Shilimkar Subject: Re: [PATCH 3/6] clk: keystone: make use of of_clk_parent_fill helper function References: <1433972965-24974-1-git-send-email-dinguyen@opensource.altera.com> <1433972965-24974-4-git-send-email-dinguyen@opensource.altera.com> In-Reply-To: <1433972965-24974-4-git-send-email-dinguyen@opensource.altera.com> Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 6/10/2015 2:49 PM, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen > > Use of_clk_parent_fill to fill in the parent clock names' array. > > Signed-off-by: Dinh Nguyen > Cc: Santosh Shilimkar > --- > drivers/clk/keystone/pll.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Looks fine by me. Acked-by: Santosh Shilimkar > diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c > index 0dd8a4b..d885372 100644 > --- a/drivers/clk/keystone/pll.c > +++ b/drivers/clk/keystone/pll.c > @@ -293,8 +293,7 @@ static void __init of_pll_mux_clk_init(struct device_node *node) > return; > } > > - parents[0] = of_clk_get_parent_name(node, 0); > - parents[1] = of_clk_get_parent_name(node, 1); > + of_clk_parent_fill(node, parents, 2); > if (!parents[0] || !parents[1]) { > pr_err("%s: missing parent clocks\n", __func__); > return; >