From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Thomas Abraham <thomas.ab@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kevin Hilman <khilman@linaro.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Anand Moon <linux.amoon@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [PATCH v2 5/7] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property
Date: Fri, 10 Jul 2015 17:35:34 +0900 [thread overview]
Message-ID: <559F83D6.8040409@samsung.com> (raw)
In-Reply-To: <1436456621-29839-6-git-send-email-b.zolnierkie@samsung.com>
On 10.07.2015 00:43, Bartlomiej Zolnierkiewicz wrote:
> For Exynos4x12 platforms, add CPU operating points (using
> opp-v2 bindings) and CPU regulator supply properties for
> migrating from Exynos specific cpufreq driver to using
> generic cpufreq driver.
>
> Based on the earlier work by Thomas Abraham.
>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Andreas Faerber <afaerber@suse.de>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> arch/arm/boot/dts/exynos4212.dtsi | 81 ++++++++++++++++++++++++
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ++
> arch/arm/boot/dts/exynos4412-origen.dts | 5 ++
> arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++
> arch/arm/boot/dts/exynos4412.dtsi | 83 +++++++++++++++++++++++++
> 5 files changed, 178 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index d9c8efee..9dc40d5 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -30,6 +30,9 @@
> device_type = "cpu";
> compatible = "arm,cortex-a9";
> reg = <0xA00>;
> + clocks = <&clock CLK_ARM_CLK>;
> + clock-names = "cpu";
> + operating-points-v2 = <&cpu0_opp_table>;
> cooling-min-level = <13>;
> cooling-max-level = <7>;
> #cooling-cells = <2>; /* min followed by max */
> @@ -39,6 +42,84 @@
> device_type = "cpu";
> compatible = "arm,cortex-a9";
> reg = <0xA01>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + };
> + };
> +
> + cpu0_opp_table: opp_table0 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = <200000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <200000>;
> + };
> + opp01 {
> + opp-hz = <300000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <200000>;
> + };
> + opp02 {
> + opp-hz = <400000000>;
> + opp-microvolt = <925000>;
> + clock-latency-ns = <200000>;
> + };
> + opp03 {
> + opp-hz = <500000000>;
> + opp-microvolt = <950000>;
> + clock-latency-ns = <200000>;
> + };
> + opp04 {
> + opp-hz = <600000000>;
> + opp-microvolt = <975000>;
> + clock-latency-ns = <200000>;
> + };
> + opp05 {
> + opp-hz = <700000000>;
> + opp-microvolt = <987500>;
> + clock-latency-ns = <200000>;
> + };
> + opp06 {
> + opp-hz = <800000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <200000>;
> + };
> + opp07 {
> + opp-hz = <900000000>;
> + opp-microvolt = <1037500>;
> + clock-latency-ns = <200000>;
> + };
> + opp08 {
> + opp-hz = <1000000000>;
> + opp-microvolt = <1087500>;
> + clock-latency-ns = <200000>;
> + };
> + opp09 {
> + opp-hz = <1100000000>;
> + opp-microvolt = <1137500>;
> + clock-latency-ns = <200000>;
> + };
> + opp10 {
> + opp-hz = <1200000000>;
> + opp-microvolt = <1187500>;
> + clock-latency-ns = <200000>;
> + };
> + opp11 {
> + opp-hz = <1300000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <200000>;
> + };
> + opp12 {
> + opp-hz = <1400000000>;
> + opp-microvolt = <1287500>;
> + clock-latency-ns = <200000>;
> + };
> + opp13 {
> + opp-hz = <1500000000>;
> + opp-microvolt = <1350000>;
> + clock-latency-ns = <200000>;
> + turbo-mode;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index ca7d168..1c7811a 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -507,3 +507,7 @@
> &watchdog {
> status = "okay";
> };
> +
> +&cpu0 {
> + cpu0-supply = <&buck2_reg>;
> +};
Can you put this in alphabetical order (before ehci node)?
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index 84c7631..21150b4 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -532,3 +532,8 @@
> &watchdog {
> status = "okay";
> };
> +
> +
> +&cpu0 {
> + cpu0-supply = <&buck2_reg>;
> +};
Ditto
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index afc199d..1ee43456 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -1313,3 +1313,8 @@
> vtmu-supply = <&ldo10_reg>;
> status = "okay";
> };
> +
> +
> +&cpu0 {
> + cpu0-supply = <&buck2_reg>;
> +};
The same.
Rest looks fine, so with the re-ordering:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> index b78ada7..cead3a7 100644
> --- a/arch/arm/boot/dts/exynos4412.dtsi
> +++ b/arch/arm/boot/dts/exynos4412.dtsi
> @@ -30,6 +30,9 @@
> device_type = "cpu";
> compatible = "arm,cortex-a9";
> reg = <0xA00>;
> + clocks = <&clock CLK_ARM_CLK>;
> + clock-names = "cpu";
> + operating-points-v2 = <&cpu0_opp_table>;
> cooling-min-level = <13>;
> cooling-max-level = <7>;
> #cooling-cells = <2>; /* min followed by max */
> @@ -39,18 +42,98 @@
> device_type = "cpu";
> compatible = "arm,cortex-a9";
> reg = <0xA01>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu@A02 {
> device_type = "cpu";
> compatible = "arm,cortex-a9";
> reg = <0xA02>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu@A03 {
> device_type = "cpu";
> compatible = "arm,cortex-a9";
> reg = <0xA03>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + };
> + };
> +
> + cpu0_opp_table: opp_table0 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = <200000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <200000>;
> + };
> + opp01 {
> + opp-hz = <300000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <200000>;
> + };
> + opp02 {
> + opp-hz = <400000000>;
> + opp-microvolt = <925000>;
> + clock-latency-ns = <200000>;
> + };
> + opp03 {
> + opp-hz = <500000000>;
> + opp-microvolt = <950000>;
> + clock-latency-ns = <200000>;
> + };
> + opp04 {
> + opp-hz = <600000000>;
> + opp-microvolt = <975000>;
> + clock-latency-ns = <200000>;
> + };
> + opp05 {
> + opp-hz = <700000000>;
> + opp-microvolt = <987500>;
> + clock-latency-ns = <200000>;
> + };
> + opp06 {
> + opp-hz = <800000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <200000>;
> + };
> + opp07 {
> + opp-hz = <900000000>;
> + opp-microvolt = <1037500>;
> + clock-latency-ns = <200000>;
> + };
> + opp08 {
> + opp-hz = <1000000000>;
> + opp-microvolt = <1087500>;
> + clock-latency-ns = <200000>;
> + };
> + opp09 {
> + opp-hz = <1100000000>;
> + opp-microvolt = <1137500>;
> + clock-latency-ns = <200000>;
> + };
> + opp10 {
> + opp-hz = <1200000000>;
> + opp-microvolt = <1187500>;
> + clock-latency-ns = <200000>;
> + };
> + opp11 {
> + opp-hz = <1300000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <200000>;
> + };
> + opp12 {
> + opp-hz = <1400000000>;
> + opp-microvolt = <1287500>;
> + clock-latency-ns = <200000>;
> + };
> + opp13 {
> + opp-hz = <1500000000>;
> + opp-microvolt = <1350000>;
> + clock-latency-ns = <200000>;
> + turbo-mode;
> };
> };
>
>
next prev parent reply other threads:[~2015-07-10 8:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 15:43 [PATCH v2 0/7] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz
2015-07-09 15:43 ` [PATCH v2 1/7] opp: add dev_pm_opp_get_turbo_mode_setting() helper Bartlomiej Zolnierkiewicz
2015-07-10 2:17 ` Krzysztof Kozlowski
2015-07-27 8:33 ` Viresh Kumar
2015-07-09 15:43 ` [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Bartlomiej Zolnierkiewicz
2015-07-10 2:20 ` Krzysztof Kozlowski
2015-07-27 8:35 ` Viresh Kumar
2015-07-27 10:24 ` Bartlomiej Zolnierkiewicz
2015-07-27 10:35 ` Viresh Kumar
2015-07-27 11:14 ` Bartlomiej Zolnierkiewicz
2015-07-27 11:36 ` Viresh Kumar
2015-07-27 11:47 ` Bartlomiej Zolnierkiewicz
2015-07-30 14:37 ` Kukjin Kim
2015-07-31 18:58 ` Bartlomiej Zolnierkiewicz
2015-08-04 1:31 ` Krzysztof Kozlowski
2015-07-09 15:43 ` [PATCH v2 3/7] cpufreq-dt: add turbo modes support Bartlomiej Zolnierkiewicz
2015-07-10 8:22 ` Krzysztof Kozlowski
2015-07-27 8:37 ` Viresh Kumar
2015-07-27 11:01 ` Bartlomiej Zolnierkiewicz
2015-07-27 11:33 ` Viresh Kumar
2015-07-27 11:58 ` Bartlomiej Zolnierkiewicz
2015-07-27 12:01 ` Viresh Kumar
2015-07-09 15:43 ` [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock Bartlomiej Zolnierkiewicz
2015-07-10 8:30 ` Krzysztof Kozlowski
2015-07-10 16:12 ` Javier Martinez Canillas
2015-07-11 6:36 ` Krzysztof Kozlowski
2015-07-15 9:58 ` Sylwester nawrocki
2015-07-09 15:43 ` [PATCH v2 5/7] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property Bartlomiej Zolnierkiewicz
2015-07-10 8:35 ` Krzysztof Kozlowski [this message]
2015-07-09 15:43 ` [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Bartlomiej Zolnierkiewicz
2015-07-10 8:55 ` Krzysztof Kozlowski
2015-07-09 15:43 ` [PATCH v2 7/7] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support Bartlomiej Zolnierkiewicz
2015-07-10 8:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559F83D6.8040409@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=afaerber@suse.de \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=javier@dowhile0.org \
--cc=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@linaro.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tomasz.figa@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).