[PATCH 00/23] ARM: at91: Properly handle slow clock

[PATCH 00/23] ARM: at91: Properly handle slow clock

[Alexandre Belloni]

Hi,

It was discovered that all the slow clock user were not properly claiming it.
This can end up in a system hang because the last registered user is releasing
it, and it gets disabled.

commit dca1a4b5ff6e ("clk: at91: keep slow clk enabled to prevent system hang")
was a workaround. This series is adding the slow clock to the necessary drivers
to avoid the issue and then removes that workaround.

The Documentation updates and DT patches should probably go through the AT91
tree this cycle to avoid breakage.

Then the other patches can go through each subsystem tree. They are trivial
enough to also go in this cycle.

The final clk patch depends on the other ones and may be taken for the next
cycle to avoid synchronization issues.

I've thrown in a cleanup for at91-reset as it avoids adding support for that
clock to the platform data initialization

Changes in v2:
 - statisticize the global in the atmel-st change
 - merge at91_reset_of_probe() in at91_reset_probe()
 - added patches from Boris for the TCB
 - added the slow clock to the TCB

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-clk@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-pwm@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: rtc-linux@googlegroups.com
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Wim Van Sebroeck <wim@iguana.be>

Alexandre Belloni (20):
  Documentation: dt: atmel-at91: add clocks to system timer, rstc and
    shdwc
  Documentation: watchdog: at91sam9_wdt: add clocks property
  Documentation: dt: rtc: at91rm9200: add clocks property
  ARM: at91/dt: at91rm9200: use slow clock where necessary
  ARM: at91/dt: at91sam9260: use slow clock where necessary
  ARM: at91/dt: at91sam9261: use slow clock where necessary
  ARM: at91/dt: at91sam9263: use slow clock where necessary
  ARM: at91/dt: at91sam9g45: use slow clock where necessary
  ARM: at91/dt: at91sam9n12: use slow clock where necessary
  ARM: at91/dt: at91sam9rl: use slow clock where necessary
  ARM: at91/dt: at91sam9x5: use slow clock where necessary
  ARM: at91/dt: sama5d3: use slow clock where necessary
  ARM: at91/dt: sama5d4: use slow clock where necessary
  rtc: at91rm9200: get and use slow clock
  watchdog: at91sam9: get and use slow clock
  power/reset: at91-reset: remove useless at91_reset_platform_probe()
  power/reset: at91-reset: get and use slow clock
  power/reset: at91-poweroff: get and use slow clock
  clocksource: atmel-st: get and use slow clock
  clk: at91: Revert "keep slow clk enabled to prevent system hang"

Boris Brezillon (3):
  Documentation: dt: atmel-at91: add slow clock to tcb
  clocksource: tcb_clksrc: fix setup_clkevents error path
  misc: atmel_tclib: get and use slow clock

 .../devicetree/bindings/arm/atmel-at91.txt         | 13 +++--
 .../bindings/rtc/atmel,at91rm9200-rtc.txt          |  2 +
 .../devicetree/bindings/watchdog/atmel-wdt.txt     |  2 +
 arch/arm/boot/dts/at91rm9200.dtsi                  | 10 ++--
 arch/arm/boot/dts/at91sam9260.dtsi                 | 11 +++--
 arch/arm/boot/dts/at91sam9261.dtsi                 |  7 ++-
 arch/arm/boot/dts/at91sam9263.dtsi                 |  7 ++-
 arch/arm/boot/dts/at91sam9g45.dtsi                 | 12 +++--
 arch/arm/boot/dts/at91sam9n12.dtsi                 | 12 +++--
 arch/arm/boot/dts/at91sam9rl.dtsi                  |  8 ++-
 arch/arm/boot/dts/at91sam9x5.dtsi                  | 12 +++--
 arch/arm/boot/dts/sama5d3.dtsi                     |  8 ++-
 arch/arm/boot/dts/sama5d3_tcb1.dtsi                |  4 +-
 arch/arm/boot/dts/sama5d4.dtsi                     | 12 +++--
 drivers/clk/at91/clk-slow.c                        | 27 ----------
 drivers/clocksource/tcb_clksrc.c                   | 10 +++-
 drivers/clocksource/timer-atmel-st.c               | 31 ++++++++----
 drivers/misc/atmel_tclib.c                         |  4 ++
 drivers/power/reset/at91-poweroff.c                | 13 +++++
 drivers/power/reset/at91-reset.c                   | 57 ++++++----------------
 drivers/pwm/pwm-atmel-tcb.c                        | 23 ++++++---
 drivers/rtc/rtc-at91rm9200.c                       | 27 ++++++++--
 drivers/watchdog/at91sam9_wdt.c                    | 22 ++++++++-
 include/linux/atmel_tc.h                           |  1 +
 24 files changed, 206 insertions(+), 129 deletions(-)

-- 
2.1.4

[PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Alexandre Belloni]

Commit dca1a4b5ff6e ("clk: at91: keep slow clk enabled to prevent system
hang") added a workaround for the slow clock as it is not properly handled
by its users.

Now that the slow clock is taken properly by the drivers, this workaround
is not necessary anymore, revert it.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-clk@vger.kernel.org
 drivers/clk/at91/clk-slow.c | 27 ---------------------------
 1 file changed, 27 deletions(-)

diff --git a/drivers/clk/at91/clk-slow.c b/drivers/clk/at91/clk-slow.c
index 98a84a865fe1..2c59d6a64dd5 100644
--- a/drivers/clk/at91/clk-slow.c
+++ b/drivers/clk/at91/clk-slow.c
@@ -70,7 +70,6 @@ struct clk_sam9x5_slow {
 
 #define to_clk_sam9x5_slow(hw) container_of(hw, struct clk_sam9x5_slow, hw)
 
-static struct clk *slow_clk;
 
 static int clk_slow_osc_prepare(struct clk_hw *hw)
 {
@@ -358,8 +357,6 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr,
 	clk = clk_register(NULL, &slowck->hw);
 	if (IS_ERR(clk))
 		kfree(slowck);
-	else
-		slow_clk = clk;
 
 	return clk;
 }
@@ -436,8 +433,6 @@ at91_clk_register_sam9260_slow(struct at91_pmc *pmc,
 	clk = clk_register(NULL, &slowck->hw);
 	if (IS_ERR(clk))
 		kfree(slowck);
-	else
-		slow_clk = clk;
 
 	return clk;
 }
@@ -470,25 +465,3 @@ void __init of_at91sam9260_clk_slow_setup(struct device_node *np,
 
 	of_clk_add_provider(np, of_clk_src_simple_get, clk);
 }
-
-/*
- * FIXME: All slow clk users are not properly claiming it (get + prepare +
- * enable) before using it.
- * If all users properly claiming this clock decide that they don't need it
- * anymore (or are removed), it is disabled while faulty users are still
- * requiring it, and the system hangs.
- * Prevent this clock from being disabled until all users are properly
- * requesting it.
- * Once this is done we should remove this function and the slow_clk variable.
- */
-static int __init of_at91_clk_slow_retain(void)
-{
-	if (!slow_clk)
-		return 0;
-
-	__clk_get(slow_clk);
-	clk_prepare_enable(slow_clk);
-
-	return 0;
-}
-arch_initcall(of_at91_clk_slow_retain);
-- 
2.1.4

Re: [PATCH 00/23] ARM: at91: Properly handle slow clock

[Boris Brezillon]

Hi Alexandre,

On Fri, 31 Jul 2015 11:39:36 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> Hi,
> 
> It was discovered that all the slow clock user were not properly claiming it.
> This can end up in a system hang because the last registered user is releasing
> it, and it gets disabled.
> 
> commit dca1a4b5ff6e ("clk: at91: keep slow clk enabled to prevent system hang")
> was a workaround. This series is adding the slow clock to the necessary drivers
> to avoid the issue and then removes that workaround.
> 
> The Documentation updates and DT patches should probably go through the AT91
> tree this cycle to avoid breakage.
> 
> Then the other patches can go through each subsystem tree. They are trivial
> enough to also go in this cycle.
> 
> The final clk patch depends on the other ones and may be taken for the next
> cycle to avoid synchronization issues.
> 
> I've thrown in a cleanup for at91-reset as it avoids adding support for that
> clock to the platform data initialization

I would have squashed commit 5 to 14 into a single patch, but apart
from that it looks good to me.

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

> 
> Changes in v2:
>  - statisticize the global in the atmel-st change
>  - merge at91_reset_of_probe() in at91_reset_probe()
>  - added patches from Boris for the TCB
>  - added the slow clock to the TCB
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-watchdog@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: rtc-linux@googlegroups.com
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> 
> Alexandre Belloni (20):
>   Documentation: dt: atmel-at91: add clocks to system timer, rstc and
>     shdwc
>   Documentation: watchdog: at91sam9_wdt: add clocks property
>   Documentation: dt: rtc: at91rm9200: add clocks property
>   ARM: at91/dt: at91rm9200: use slow clock where necessary
>   ARM: at91/dt: at91sam9260: use slow clock where necessary
>   ARM: at91/dt: at91sam9261: use slow clock where necessary
>   ARM: at91/dt: at91sam9263: use slow clock where necessary
>   ARM: at91/dt: at91sam9g45: use slow clock where necessary
>   ARM: at91/dt: at91sam9n12: use slow clock where necessary
>   ARM: at91/dt: at91sam9rl: use slow clock where necessary
>   ARM: at91/dt: at91sam9x5: use slow clock where necessary
>   ARM: at91/dt: sama5d3: use slow clock where necessary
>   ARM: at91/dt: sama5d4: use slow clock where necessary
>   rtc: at91rm9200: get and use slow clock
>   watchdog: at91sam9: get and use slow clock
>   power/reset: at91-reset: remove useless at91_reset_platform_probe()
>   power/reset: at91-reset: get and use slow clock
>   power/reset: at91-poweroff: get and use slow clock
>   clocksource: atmel-st: get and use slow clock
>   clk: at91: Revert "keep slow clk enabled to prevent system hang"
> 
> Boris Brezillon (3):
>   Documentation: dt: atmel-at91: add slow clock to tcb
>   clocksource: tcb_clksrc: fix setup_clkevents error path
>   misc: atmel_tclib: get and use slow clock
> 
>  .../devicetree/bindings/arm/atmel-at91.txt         | 13 +++--
>  .../bindings/rtc/atmel,at91rm9200-rtc.txt          |  2 +
>  .../devicetree/bindings/watchdog/atmel-wdt.txt     |  2 +
>  arch/arm/boot/dts/at91rm9200.dtsi                  | 10 ++--
>  arch/arm/boot/dts/at91sam9260.dtsi                 | 11 +++--
>  arch/arm/boot/dts/at91sam9261.dtsi                 |  7 ++-
>  arch/arm/boot/dts/at91sam9263.dtsi                 |  7 ++-
>  arch/arm/boot/dts/at91sam9g45.dtsi                 | 12 +++--
>  arch/arm/boot/dts/at91sam9n12.dtsi                 | 12 +++--
>  arch/arm/boot/dts/at91sam9rl.dtsi                  |  8 ++-
>  arch/arm/boot/dts/at91sam9x5.dtsi                  | 12 +++--
>  arch/arm/boot/dts/sama5d3.dtsi                     |  8 ++-
>  arch/arm/boot/dts/sama5d3_tcb1.dtsi                |  4 +-
>  arch/arm/boot/dts/sama5d4.dtsi                     | 12 +++--
>  drivers/clk/at91/clk-slow.c                        | 27 ----------
>  drivers/clocksource/tcb_clksrc.c                   | 10 +++-
>  drivers/clocksource/timer-atmel-st.c               | 31 ++++++++----
>  drivers/misc/atmel_tclib.c                         |  4 ++
>  drivers/power/reset/at91-poweroff.c                | 13 +++++
>  drivers/power/reset/at91-reset.c                   | 57 ++++++----------------
>  drivers/pwm/pwm-atmel-tcb.c                        | 23 ++++++---
>  drivers/rtc/rtc-at91rm9200.c                       | 27 ++++++++--
>  drivers/watchdog/at91sam9_wdt.c                    | 22 ++++++++-
>  include/linux/atmel_tc.h                           |  1 +
>  24 files changed, 206 insertions(+), 129 deletions(-)
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH 00/23] ARM: at91: Properly handle slow clock

[Alexandre Belloni]

Hi,

On 31/07/2015 at 11:59:03 +0200, Boris Brezillon wrote :
> I would have squashed commit 5 to 14 into a single patch, but apart
> from that it looks good to me.
> 

I wanted to clearly list were the slow clock was needed for each soc. It
actually allowed me to find one that was missing.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 00/23] ARM: at91: Properly handle slow clock

[Alexandre Belloni]

Hi,

I realize now that I forgot to add the v2 tag in the subject lines. This
is really v2 :)

On 31/07/2015 at 11:39:36 +0200, Alexandre Belloni wrote :
> Hi,
> 
> It was discovered that all the slow clock user were not properly claiming it.
> This can end up in a system hang because the last registered user is releasing
> it, and it gets disabled.
> 
> commit dca1a4b5ff6e ("clk: at91: keep slow clk enabled to prevent system hang")
> was a workaround. This series is adding the slow clock to the necessary drivers
> to avoid the issue and then removes that workaround.
> 
> The Documentation updates and DT patches should probably go through the AT91
> tree this cycle to avoid breakage.
> 
> Then the other patches can go through each subsystem tree. They are trivial
> enough to also go in this cycle.
> 
> The final clk patch depends on the other ones and may be taken for the next
> cycle to avoid synchronization issues.
> 
> I've thrown in a cleanup for at91-reset as it avoids adding support for that
> clock to the platform data initialization
> 
> Changes in v2:
>  - statisticize the global in the atmel-st change
>  - merge at91_reset_of_probe() in at91_reset_probe()
>  - added patches from Boris for the TCB
>  - added the slow clock to the TCB
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-watchdog@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: rtc-linux@googlegroups.com
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> 
> Alexandre Belloni (20):
>   Documentation: dt: atmel-at91: add clocks to system timer, rstc and
>     shdwc
>   Documentation: watchdog: at91sam9_wdt: add clocks property
>   Documentation: dt: rtc: at91rm9200: add clocks property
>   ARM: at91/dt: at91rm9200: use slow clock where necessary
>   ARM: at91/dt: at91sam9260: use slow clock where necessary
>   ARM: at91/dt: at91sam9261: use slow clock where necessary
>   ARM: at91/dt: at91sam9263: use slow clock where necessary
>   ARM: at91/dt: at91sam9g45: use slow clock where necessary
>   ARM: at91/dt: at91sam9n12: use slow clock where necessary
>   ARM: at91/dt: at91sam9rl: use slow clock where necessary
>   ARM: at91/dt: at91sam9x5: use slow clock where necessary
>   ARM: at91/dt: sama5d3: use slow clock where necessary
>   ARM: at91/dt: sama5d4: use slow clock where necessary
>   rtc: at91rm9200: get and use slow clock
>   watchdog: at91sam9: get and use slow clock
>   power/reset: at91-reset: remove useless at91_reset_platform_probe()
>   power/reset: at91-reset: get and use slow clock
>   power/reset: at91-poweroff: get and use slow clock
>   clocksource: atmel-st: get and use slow clock
>   clk: at91: Revert "keep slow clk enabled to prevent system hang"
> 
> Boris Brezillon (3):
>   Documentation: dt: atmel-at91: add slow clock to tcb
>   clocksource: tcb_clksrc: fix setup_clkevents error path
>   misc: atmel_tclib: get and use slow clock
> 
>  .../devicetree/bindings/arm/atmel-at91.txt         | 13 +++--
>  .../bindings/rtc/atmel,at91rm9200-rtc.txt          |  2 +
>  .../devicetree/bindings/watchdog/atmel-wdt.txt     |  2 +
>  arch/arm/boot/dts/at91rm9200.dtsi                  | 10 ++--
>  arch/arm/boot/dts/at91sam9260.dtsi                 | 11 +++--
>  arch/arm/boot/dts/at91sam9261.dtsi                 |  7 ++-
>  arch/arm/boot/dts/at91sam9263.dtsi                 |  7 ++-
>  arch/arm/boot/dts/at91sam9g45.dtsi                 | 12 +++--
>  arch/arm/boot/dts/at91sam9n12.dtsi                 | 12 +++--
>  arch/arm/boot/dts/at91sam9rl.dtsi                  |  8 ++-
>  arch/arm/boot/dts/at91sam9x5.dtsi                  | 12 +++--
>  arch/arm/boot/dts/sama5d3.dtsi                     |  8 ++-
>  arch/arm/boot/dts/sama5d3_tcb1.dtsi                |  4 +-
>  arch/arm/boot/dts/sama5d4.dtsi                     | 12 +++--
>  drivers/clk/at91/clk-slow.c                        | 27 ----------
>  drivers/clocksource/tcb_clksrc.c                   | 10 +++-
>  drivers/clocksource/timer-atmel-st.c               | 31 ++++++++----
>  drivers/misc/atmel_tclib.c                         |  4 ++
>  drivers/power/reset/at91-poweroff.c                | 13 +++++
>  drivers/power/reset/at91-reset.c                   | 57 ++++++----------------
>  drivers/pwm/pwm-atmel-tcb.c                        | 23 ++++++---
>  drivers/rtc/rtc-at91rm9200.c                       | 27 ++++++++--
>  drivers/watchdog/at91sam9_wdt.c                    | 22 ++++++++-
>  include/linux/atmel_tc.h                           |  1 +
>  24 files changed, 206 insertions(+), 129 deletions(-)
> 
> -- 
> 2.1.4
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Stephen Boyd]

On 07/31/2015 02:39 AM, Alexandre Belloni wrote:
> -	clk_prepare_enable(slow_clk);
> -
> -	return 0;
> -}
> -arch_initcall(of_at91_clk_slow_retain);

Can you drop the include of clk.h in this file too?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Alexandre Belloni]

On 31/07/2015 at 12:00:28 -0700, Stephen Boyd wrote :
> On 07/31/2015 02:39 AM, Alexandre Belloni wrote:
> >-	clk_prepare_enable(slow_clk);
> >-
> >-	return 0;
> >-}
> >-arch_initcall(of_at91_clk_slow_retain);
> 
> Can you drop the include of clk.h in this file too?
> 

Sure! I will do that in v3. However, I'll wait for some feedback from
the other maintainers before sending again.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Stephen Boyd]

On 07/31/2015 02:09 PM, Alexandre Belloni wrote:
> On 31/07/2015 at 12:00:28 -0700, Stephen Boyd wrote :
>> On 07/31/2015 02:39 AM, Alexandre Belloni wrote:
>>> -	clk_prepare_enable(slow_clk);
>>> -
>>> -	return 0;
>>> -}
>>> -arch_initcall(of_at91_clk_slow_retain);
>> Can you drop the include of clk.h in this file too?
>>
> Sure! I will do that in v3. However, I'll wait for some feedback from
> the other maintainers before sending again.
>

Cool. Also, are you going to take this through arm-soc? If so, feel free 
to add my ack.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Alexandre Belloni]

On 31/07/2015 at 14:11:27 -0700, Stephen Boyd wrote :
> On 07/31/2015 02:09 PM, Alexandre Belloni wrote:
> >On 31/07/2015 at 12:00:28 -0700, Stephen Boyd wrote :
> >>On 07/31/2015 02:39 AM, Alexandre Belloni wrote:
> >>>-	clk_prepare_enable(slow_clk);
> >>>-
> >>>-	return 0;
> >>>-}
> >>>-arch_initcall(of_at91_clk_slow_retain);
> >>Can you drop the include of clk.h in this file too?
> >>
> >Sure! I will do that in v3. However, I'll wait for some feedback from
> >the other maintainers before sending again.
> >
> 
> Cool. Also, are you going to take this through arm-soc? If so, feel free to
> add my ack.
> 

Actually, clk.h has never been included in that file.

I was thinking you could take it once the other patch made it in each
subsystem. It is not urgent, it can probably skip one or two cycles.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Stephen Boyd]

On 07/31/2015 02:27 PM, Alexandre Belloni wrote:
> On 31/07/2015 at 14:11:27 -0700, Stephen Boyd wrote :
>> On 07/31/2015 02:09 PM, Alexandre Belloni wrote:
>>> On 31/07/2015 at 12:00:28 -0700, Stephen Boyd wrote :
>>>> On 07/31/2015 02:39 AM, Alexandre Belloni wrote:
>>>>> -	clk_prepare_enable(slow_clk);
>>>>> -
>>>>> -	return 0;
>>>>> -}
>>>>> -arch_initcall(of_at91_clk_slow_retain);
>>>> Can you drop the include of clk.h in this file too?
>>>>
>>> Sure! I will do that in v3. However, I'll wait for some feedback from
>>> the other maintainers before sending again.
>>>
>> Cool. Also, are you going to take this through arm-soc? If so, feel free to
>> add my ack.
>>
> Actually, clk.h has never been included in that file.
>
> I was thinking you could take it once the other patch made it in each
> subsystem. It is not urgent, it can probably skip one or two cycles.
>

Ok that's fine. I added clk.h into this file when I removed clk.h from 
clk-provider.h so that it keeps compiling. Please remind us to pick this 
up when you think it's ready.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang"

[Alexandre Belloni]

On 31/07/2015 at 14:34:25 -0700, Stephen Boyd wrote :
> Ok that's fine. I added clk.h into this file when I removed clk.h from
> clk-provider.h so that it keeps compiling. Please remind us to pick this up
> when you think it's ready.
> 

Ah right, then I'll try to remember to remove it before resending.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com