From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <55C9DF7B.4040308@st.com> Date: Tue, 11 Aug 2015 13:41:47 +0200 From: Maxime Coquelin MIME-Version: 1.0 To: Geert Uytterhoeven CC: Lee Jones , Michael Turquette , "linux-kernel@vger.kernel.org" , , Stephen Boyd , Maxime Ripard , Sascha Hauer Subject: Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag References: <1438974570-20812-1-git-send-email-mturquette@baylibre.com> <1438974570-20812-4-git-send-email-mturquette@baylibre.com> <20150810144811.GN3249@x1> <20150810185516.2416.32293@quantum> <20150811084329.GA13374@x1> <55C9C82F.6060401@st.com> <55C9DE57.2090105@st.com> In-Reply-To: <55C9DE57.2090105@st.com> Content-Type: text/plain; charset="utf-8"; format=flowed List-ID: Sorry Geert, my reply has been cut: On 08/11/2015 01:36 PM, Maxime Coquelin wrote: > Hi Geert, > > On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: >> Hi Maxime, >> >> On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin >> wrote: >>> How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi >>> platform? >> Add the flag to the relevant clocks in the C code, e.g. in >> clk_register_flexgen(): >> >> if (!strcmp(name, "clk-icn-cpu")) >> init.flags |= CLK_ENABLE_HAND_OFF; The main problem I see with this proposal is that clk_register_flexgen() is called for several SoCs (STiH407/410/418...). Each of these SoCs have this clock, but maybe STiH407 will need the flag, but not STiH410 and STiH418. So I think the best place to set this information is in DT, where the differentiation is made between the SoCs. Kind regards, Maxime