From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:20223 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbbHQAhi (ORCPT ); Sun, 16 Aug 2015 20:37:38 -0400 Message-id: <55D12CC9.2060602@samsung.com> Date: Mon, 17 Aug 2015 09:37:29 +0900 From: Krzysztof Kozlowski MIME-version: 1.0 To: Chanwoo Choi Cc: Sylwester Nawrocki , tomasz.figa@gmail.com, kgene@kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] ARM: dts: exynos3250: Add UART2 and MMC2 dt node with related clocks References: <1439264784-30322-1-git-send-email-cw00.choi@samsung.com> <55D12C73.6090101@samsung.com> In-reply-to: <55D12C73.6090101@samsung.com> Content-type: text/plain; charset=utf-8 Sender: linux-clk-owner@vger.kernel.org List-ID: On 17.08.2015 09:36, Chanwoo Choi wrote: > On 08/17/2015 09:33 AM, Krzysztof Kozlowski wrote: >> 2015-08-11 12:46 GMT+09:00 Chanwoo Choi : >>> This patch add the UART2 / MMC2 devicetree node for Exynos3250 SoC and add >>> the related clocks (mux, divider, gate) of UART2 / MMC2 device. >> >> What is the benefit of adding them? Why they are needed? > > UART2 /MMC2 are used on Exynos3250-based ARTIK-5 board[1]. > [1] https://www.artik.io/hardware/artik-5 Thanks for explaining this. The patchset missed that information - the purpose. I'll start reviewing it. Best regards, Krzysztof > > Thanks, > Chanwoo Choi > >> >> Best regards, >> Krzysztof >> >> >>> >>> Chanwoo Choi (4): >>> clk: samsung: exynos3250: Add UART2 clock >>> clk: samsung: exynos3250: Add MMC2 clock >>> ARM: dts: Add UART2 dt node for Exynos3250 SoC >>> ARM: dts: Add MSHC2 dt node for Exynos3250 SoC >>> >>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 42 +++++++++++++++++++++++++++++++ >>> arch/arm/boot/dts/exynos3250.dtsi | 25 ++++++++++++++++++ >>> drivers/clk/samsung/clk-exynos3250.c | 15 +++++++++++ >>> include/dt-bindings/clock/exynos3250.h | 11 +++++++- >>> 4 files changed, 92 insertions(+), 1 deletion(-) >>> >>> -- >>> 1.8.5.5 >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > >