From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] drivers: soc: qcom: rpmpd: Fix MSM8976 power domains setup
Date: Mon, 24 Jul 2023 10:48:30 +0200 [thread overview]
Message-ID: <55e72667-dec5-dab0-9d1b-dc127fe4d065@collabora.com> (raw)
In-Reply-To: <20230723140712.9438-2-a39.skl@gmail.com>
Il 23/07/23 16:06, Adam Skladowski ha scritto:
> Downstream kernel parses resource names based on pm8950-rpm-regulator.dtsi
> in such file qcom,resource-name takes three values: smpa,ldoa and clk0.
> First appearance of RWSC/RWSM point to msm-4.4 kernel
Are we sure that RWSC/RWSM being present isn't firmware-related?
What is the observed issue, why are you removing RWSC/RWSM and what did you
solve with that?
If it's just about dropping unused resources, that may be unused only on
firmware versions older than "X".
> which is way newer than what this platform was shipped with (msm-3.10).
> For the max_state downstream code limit value to TURBO inside dts
> with only one turbo_high being placed in msm-thermal bindings.
> One of effects of requesting TURBO_HIGH vote is rebooting of device
> which happens during voting inside WCNSS/IRIS,
> this behavior was observed on LeEco S2 smartphone.
> Fix regulator setup and drop unused resources.
That's fine, but you're missing a Fixes tag, which is required, being this a fix.
Regards,
Angelo
next prev parent reply other threads:[~2023-07-24 8:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 14:06 [PATCH 0/7] MSM8976 PLL,RPMPD and DTS changes Adam Skladowski
2023-07-23 14:06 ` [PATCH 1/7] drivers: soc: qcom: rpmpd: Fix MSM8976 power domains setup Adam Skladowski
2023-07-24 8:48 ` AngeloGioacchino Del Regno [this message]
2023-07-23 14:06 ` [PATCH 2/7] clk: qcom: clk-hfpll: Configure l_val in init when required Adam Skladowski
2023-07-23 14:06 ` [PATCH 3/7] clk: qcom: hfpll: Allow matching pdata Adam Skladowski
2023-07-24 8:51 ` AngeloGioacchino Del Regno
2023-07-23 14:06 ` [PATCH 4/7] dt-bindings: clock: qcom,hfpll: Document MSM8976 compatibles Adam Skladowski
2023-07-23 14:34 ` Krzysztof Kozlowski
2023-07-23 14:06 ` [PATCH 5/7] clk: qcom: hfpll: Add MSM8976 PLL data Adam Skladowski
2023-07-23 14:06 ` [PATCH 6/7] arm64: dts: qcom: msm8976: Split lpass region Adam Skladowski
2023-07-24 8:54 ` AngeloGioacchino Del Regno
2023-07-23 14:06 ` [PATCH 7/7] arm64: dts: qcom: msm8976: Fix smsm ipc bit shifts Adam Skladowski
2023-07-23 16:28 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55e72667-dec5-dab0-9d1b-dc127fe4d065@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox