From: York Sun <yorksun@freescale.com>
To: Guenter Roeck <linux@roeck-us.net>, <sboyd@codeaurora.org>
Cc: <linux-clk@vger.kernel.org>,
Mike Turquette <mturquette@baylibre.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrey Filippov <andrey@elphel.com>,
Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [Patch v5] driver/clk/clk-si5338: Add common clock framework driver for si5338
Date: Fri, 25 Sep 2015 08:04:08 -0700 [thread overview]
Message-ID: <56056268.2010507@freescale.com> (raw)
In-Reply-To: <5604A9F0.2050600@roeck-us.net>
On 09/24/2015 06:57 PM, Guenter Roeck wrote:
> On 09/24/2015 05:46 PM, York Sun wrote:
>> SI5338 is a programmable clock generator. It has 4 sets of inputs,
>> PLL, multisynth and dividers to make 4 outputs. This driver splits
>> them into multiple clocks to comply with common clock framework.
>>
>> See Documentation/devicetree/bindings/clock/silabs,si5338.txt for
>> details.
>>
<snip>
>> +static inline u8 si5338_reg_read(struct si5338_driver_data *drvdata, u16 reg)
>> +{
>> + u32 val;
>> + int ret;
>> +
>> + ret = regmap_read(drvdata->regmap, reg, &val);
>> + if (ret) {
>> + dev_err(&drvdata->client->dev,
>> + "unable to read from reg %02x: return %d\n", reg, ret);
>> + return 0;
>
> Why hide the error ?
I need to comb through all the return values as you suggested. Thanks.
York
next prev parent reply other threads:[~2015-09-25 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 0:46 [Patch v5] driver/clk/clk-si5338: Add common clock framework driver for si5338 York Sun
2015-09-25 1:57 ` Guenter Roeck
2015-09-25 15:04 ` York Sun [this message]
2015-10-01 22:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56056268.2010507@freescale.com \
--to=yorksun@freescale.com \
--cc=andrey@elphel.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
--cc=pebolle@tiscali.nl \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).