From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: k.kozlowski.k@gmail.com, Alim Akhtar <alim.akhtar@samsung.com>,
Mark Brown <broonie@kernel.org>,
lee.jones@linaro.org, mturquette@baylibre.com,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Wed, 28 Oct 2015 22:31:48 +0900 [thread overview]
Message-ID: <5630CE44.7070204@samsung.com> (raw)
In-Reply-To: <20151028094853.GM22331@piout.net>
W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze:
> On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote :
>> The s2mps13 clock driver added new name and compatible... which was
>> probably totally unneeded (I missed that during review). We don't have
>> to make this as a rule...
>>
>> Since we do not have any data about future workarounds and the
>> differences then just follow Ockham's razor - use the same name and
>> compatible.
>>
>
> So you don't care about DT backward compatibility because when a
> workaround will be needed for one of the IPs, then you will have to
> update the old dtb to use it.
Nope, DTB does not contain the name for RTC driver (s2mps15-rtc). It
will be exactly the same.
>
> Unless you are sure that the IP is the same, doing
>
> { "s2mps15-rtc", S2MPS14X },
>
> is probably the best way to handle that. Note that I personally don't
> care about the DT ABI, I'm just pointing out what may happen ;)
In case of RTC driver there is no chance of DT ABI issues here.
The clock driver is different because it contain a compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-28 13:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 12:51 [PATCH v3 0/5] mfd: sec: add S2MPS15 PMIC support Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 1/5] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC Alim Akhtar
2015-10-26 14:34 ` Lee Jones
2015-10-28 1:15 ` Krzysztof Kozlowski
2015-10-28 8:46 ` Lee Jones
2015-10-28 11:21 ` Alim Akhtar
2015-10-28 13:47 ` Krzysztof Kozlowski
2015-10-28 13:44 ` Krzysztof Kozlowski
2015-10-28 13:51 ` Lee Jones
2015-10-29 4:19 ` Alim Akhtar
2015-10-28 1:28 ` Krzysztof Kozlowski
2015-10-26 12:51 ` [PATCH v3 3/5] regulator: s2mps11: add support for S2MPS15 regulators Alim Akhtar
2015-10-26 12:51 ` [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks Alim Akhtar
2015-10-28 1:22 ` Krzysztof Kozlowski
2015-10-28 3:36 ` Alim Akhtar
2015-10-28 1:26 ` Krzysztof Kozlowski
2015-10-28 4:34 ` Krzysztof Kozlowski
2015-10-28 4:55 ` Alim Akhtar
2015-10-28 5:36 ` Krzysztof Kozlowski
2015-10-26 12:51 ` [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC Alim Akhtar
2015-10-27 22:59 ` [rtc-linux] " Alexandre Belloni
2015-10-28 1:29 ` Krzysztof Kozlowski
2015-10-28 1:53 ` Mark Brown
2015-10-28 2:17 ` Krzysztof Kozlowski
2015-10-28 3:14 ` Alim Akhtar
2015-10-28 3:31 ` Krzysztof Kozlowski
2015-10-28 3:33 ` Alim Akhtar
2015-10-28 9:48 ` [rtc-linux] " Alexandre Belloni
2015-10-28 10:30 ` Alim Akhtar
2015-10-28 13:35 ` Krzysztof Kozlowski
2015-10-28 13:31 ` Krzysztof Kozlowski [this message]
2015-10-28 13:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5630CE44.7070204@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=k.kozlowski.k@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).