Re: [PATCH v2] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

Mutharaju, Prasanna (P.)
2015-11-30T08:05:18Z

On Mon, Nov 30, 2015 at 04:31:35PM +0900, Krzysztof Kozlowski wrote:
> On 30.11.2015 16:28, Mutharaju, Prasanna (P.) wrote:
> > From: Prasanna Karthik <mkarthi3@visteon.com>
> >=20
> > Remove unneeded variable used to store return value.
> > V2: Modified subject =20
>=20
> Changelog (v2) should go after '---' separator so it won't get included
> in the commit message.
>=20

Done in v3.=20

> Now I see that you Signed-off-by is okay - same email address... I got
> confused by the difference in name.

Yeah, my gitconfig and outlook account differ little.=20

> Best regards,
> Krzysztof
> >=20
> > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
> > ---
> > drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsu=
ng/clk-s3c2410-dclk.c
> > index e9eb935..ec6fb14 100644
> > --- a/drivers/clk/samsung/clk-s3c2410-dclk.c
> > +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
> > @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *=
hw)
> > static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
> > {
> > struct s3c24xx_clkout *clkout =3D to_s3c24xx_clkout(hw);
> > - int ret =3D 0;
> > =20
> > s3c2410_modify_misccr((clkout->mask << clkout->shift),
> > (index << clkout->shift));
> > =20
> > - return ret;
> > + return 0;
> > }
> > =20
> > static const struct clk_ops s3c24xx_clkout_ops =3D {
> >=20
> =