From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= Subject: Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent To: "Mutharaju, Prasanna (P.)" , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= References: <20151130095109.GA28767@jci-VirtualBox> Cc: k.kozlowski.k@gmail.com, Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" From: Krzysztof Kozlowski Message-ID: <565C1D25.602@samsung.com> Date: Mon, 30 Nov 2015 18:55:49 +0900 MIME-Version: 1.0 In-Reply-To: <20151130095109.GA28767@jci-VirtualBox> Content-Type: text/plain; charset=windows-1252 List-ID: W dniu 30.11.2015 o 18:52, Mutharaju, Prasanna (P.) pisze: > Remove unneeded variable used to store return value. > > Signed-off-by: Prasanna Karthik Previous issues fixed, thanks! But now you changed the From field and it does not match exactly the Signed-off-by (email matches but name does not). Please fix this - signed-off-by should be the same as "From" (in previous versions it was ok...). Best regards, Krzysztof > > --- > v3: Modified subject and changelog comments > --- > --- > drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c > index e9eb935..ec6fb14 100644 > --- a/drivers/clk/samsung/clk-s3c2410-dclk.c > +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c > @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw) > static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index) > { > struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw); > - int ret = 0; > > s3c2410_modify_misccr((clkout->mask << clkout->shift), > (index << clkout->shift)); > > - return ret; > + return 0; > } > > static const struct clk_ops s3c24xx_clkout_ops = { >