linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rhyland Klein <rklein@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>
Cc: <linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] clk: tegra: Fix sparse warning for pll_m
Date: Mon, 7 Dec 2015 10:50:13 -0500	[thread overview]
Message-ID: <5665AAB5.2020507@nvidia.com> (raw)
In-Reply-To: <1449248665-22343-1-git-send-email-jonathanh@nvidia.com>

On 12/4/2015 12:04 PM, Jon Hunter wrote:
> Sparse generates the following warning for the pll_m params structure:
> 
> drivers/clk/tegra/clk-tegra210.c:1569:10: warning: Initializer entry
>  defined twice
> drivers/clk/tegra/clk-tegra210.c:1570:10:   also defined here
> 
> Fix this by correcting the index for the MISC1 register.
> 
> Fixes: b31eba5ff3f7 ("clk: tegra: Add support for Tegra210 clocks")
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/clk/tegra/clk-tegra210.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
> index 58514c44ea83..3bd831c2b9db 100644
> --- a/drivers/clk/tegra/clk-tegra210.c
> +++ b/drivers/clk/tegra/clk-tegra210.c
> @@ -1567,7 +1567,7 @@ static struct tegra_clk_pll_params pll_m_params = {
>  	.iddq_bit_idx = PLLM_IDDQ_BIT,
>  	.max_p = PLL_QLIN_PDIV_MAX,
>  	.ext_misc_reg[0] = PLLM_MISC0,
> -	.ext_misc_reg[0] = PLLM_MISC1,
> +	.ext_misc_reg[1] = PLLM_MISC1,
>  	.round_p_to_pdiv = pll_qlin_p_to_pdiv,
>  	.pdiv_tohw = pll_qlin_pdiv_to_hw,
>  	.div_nmp = &pllm_nmp,
> 

Acked-by: Rhyland Klein <rklein@nvidia.com>

-- 
nvpublic

  parent reply	other threads:[~2015-12-07 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 17:04 [PATCH 1/3] clk: tegra: Fix sparse warning for pll_m Jon Hunter
2015-12-04 17:04 ` [PATCH 2/3] clk: tegra210: Fix sparse warnings for functions not declared as static Jon Hunter
2015-12-07 15:51   ` Rhyland Klein
2015-12-04 17:04 ` [PATCH 3/3] clk: tegra-super: " Jon Hunter
2015-12-07 15:51   ` Rhyland Klein
2015-12-07 17:51     ` Rhyland Klein
2015-12-08  9:55       ` Jon Hunter
2015-12-07 15:50 ` Rhyland Klein [this message]
2016-01-13 17:15 ` [PATCH 1/3] clk: tegra: Fix sparse warning for pll_m Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665AAB5.2020507@nvidia.com \
    --to=rklein@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=sboyd@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).