From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/3] clk: tegra: Fix sparse warning for pll_m To: Jon Hunter , Peter De Schrijver , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Stephen Warren , Thierry Reding , Alexandre Courbot References: <1449248665-22343-1-git-send-email-jonathanh@nvidia.com> CC: , , From: Rhyland Klein Message-ID: <5665AAB5.2020507@nvidia.com> Date: Mon, 7 Dec 2015 10:50:13 -0500 MIME-Version: 1.0 In-Reply-To: <1449248665-22343-1-git-send-email-jonathanh@nvidia.com> Content-Type: text/plain; charset="windows-1252" Return-Path: rklein@nvidia.com List-ID: On 12/4/2015 12:04 PM, Jon Hunter wrote: > Sparse generates the following warning for the pll_m params structure: > > drivers/clk/tegra/clk-tegra210.c:1569:10: warning: Initializer entry > defined twice > drivers/clk/tegra/clk-tegra210.c:1570:10: also defined here > > Fix this by correcting the index for the MISC1 register. > > Fixes: b31eba5ff3f7 ("clk: tegra: Add support for Tegra210 clocks") > > Signed-off-by: Jon Hunter > --- > drivers/clk/tegra/clk-tegra210.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > index 58514c44ea83..3bd831c2b9db 100644 > --- a/drivers/clk/tegra/clk-tegra210.c > +++ b/drivers/clk/tegra/clk-tegra210.c > @@ -1567,7 +1567,7 @@ static struct tegra_clk_pll_params pll_m_params = { > .iddq_bit_idx = PLLM_IDDQ_BIT, > .max_p = PLL_QLIN_PDIV_MAX, > .ext_misc_reg[0] = PLLM_MISC0, > - .ext_misc_reg[0] = PLLM_MISC1, > + .ext_misc_reg[1] = PLLM_MISC1, > .round_p_to_pdiv = pll_qlin_p_to_pdiv, > .pdiv_tohw = pll_qlin_pdiv_to_hw, > .div_nmp = &pllm_nmp, > Acked-by: Rhyland Klein -- nvpublic