From: "Emilio López" <emilio@elopez.com.ar>
To: Rhyland Klein <rklein@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: clk_register: Correctly initialize enable_count
Date: Tue, 9 Feb 2016 23:56:25 -0300 [thread overview]
Message-ID: <56BAA6D9.9090009@elopez.com.ar> (raw)
In-Reply-To: <1455058120-7398-1-git-send-email-rklein@nvidia.com>
Hi,
El 09/02/16 a las 19:48, Rhyland Klein escribió:
> When clocks are registered, they could be enabled already in
> hardware. As of now, the enable count will start at 0. When this
> happens, it means a clock is enabled and the framework doesn't know
> that, so it will always report it as disabled.
Keep in mind that during the boot process, towards the end, unused
clocks get disabled, so the state remains in sync. If suddenly the
enable_count on unused clocks is not 0, this will break and unused
clocks will remain on, wasting power.
http://lxr.free-electrons.com/source/drivers/clk/clk.c#L244
What issue were you having that prompted you to write this patch?
Cheers,
Emilio
next prev parent reply other threads:[~2016-02-10 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 22:48 [PATCH] clk: clk_register: Correctly initialize enable_count Rhyland Klein
2016-02-10 2:56 ` Emilio López [this message]
2016-02-10 18:34 ` Rhyland Klein
2016-02-11 21:32 ` Michael Turquette
2016-02-11 21:58 ` Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BAA6D9.9090009@elopez.com.ar \
--to=emilio@elopez.com.ar \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rklein@nvidia.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox