From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>, Stephen Boyd <sboyd@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: ti: Fix some errors found by static checkers
Date: Wed, 2 Mar 2016 17:42:33 +0200 [thread overview]
Message-ID: <56D709E9.2050505@ti.com> (raw)
In-Reply-To: <20160301235532.GD4469@atomide.com>
On 03/02/2016 01:55 AM, Tony Lindgren wrote:
> * Stephen Boyd <sboyd@codeaurora.org> [160301 10:55]:
>> drivers/clk/ti/clk-814x.c:34:12: warning: symbol 'dm814x_adpll_early_init' was not declared. Should it be static?
>> drivers/clk/ti/clk-814x.c:58:12: warning: symbol 'dm814x_adpll_enable_init_clocks' was not declared. Should it be static?
>> drivers/clk/ti/adpll.c:465 ti_adpll_recalc_rate() warn: should '__readw(d->regs + 20) << 18' be a 64 bit type?
>> drivers/clk/ti/adpll.c:945 ti_adpll_probe() error: we previously assumed 'd->clocks' could be null (see line 921)
>>
>> The last one looks like a real bug because we don't return an
>> error on allocation failure.
>
> Yeah nice, that's a real bug:
>
> Tested-by: Tony Lindgren <tony@atomide.com>
>
Looks good to me also.
Acked-by: Tero Kristo <t-kristo@ti.com>
prev parent reply other threads:[~2016-03-02 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:54 [PATCH] clk: ti: Fix some errors found by static checkers Stephen Boyd
2016-03-01 23:55 ` Tony Lindgren
2016-03-02 15:42 ` Tero Kristo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D709E9.2050505@ti.com \
--to=t-kristo@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).