From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410 To: Javier Martinez Canillas , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <1464774351-23604-1-git-send-email-k.kozlowski@samsung.com> <1464774351-23604-3-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <574FCFB2.1080607@samsung.com> Date: Thu, 02 Jun 2016 08:18:26 +0200 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 List-ID: On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote: >> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file >> shared with Exynos5410 and configure the clocks on the latter. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> >> +&sss { >> + clocks = <&clock CLK_SSS>; >> + clock-names = "secss"; >> +}; >> + > > [snip] > >> >> +&watchdog { >> + clocks = <&clock CLK_WDT>; >> + clock-names = "watchdog"; >> + samsung,syscon-phandle = <&pmu_system_controller>; >> +}; >> + > > Since you used the same ID than Exynos5420 for the SSS and WDT clocks, > I wonder if the clock and clock-names shouldn't be just defined in the > shared exynos54xx.dtsi as is the case for the interrupts that are also > the same? > > The patch looks good to me though, so whatever you decide: > > Reviewed-by: Javier Martinez Canillas Thanks for review and comments. The 'clock' property cannot be moved - there is no clock phandle and the clock IDs are not included in 54xx. Best regards, Krzysztof