[PATCH 1/6] clk: Add missing clk_get_sys() stub

[PATCH 1/6] clk: Add missing clk_get_sys() stub

[Daniel Lezcano]

When compiling with the COMPILE_TEST option set, the clps711x does not
compile because of the clk_get_sys() noop stub missing.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 include/linux/clk.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/clk.h b/include/linux/clk.h
index 0df4a51..834179f 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
 	return NULL;
 }
 
+static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
+{
+	return NULL;
+}
 #endif
 
 /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
-- 
1.9.1

Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub

[Daniel Lezcano]

On 06/02/2016 11:41 PM, Daniel Lezcano wrote:
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Added missing Cc [Mike and Stephen]

> ---
>   include/linux/clk.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
>   	return NULL;
>   }
>
> +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
> +{
> +	return NULL;
> +}
>   #endif
>
>   /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub

[Daniel Lezcano]

On 06/02/2016 11:41 PM, Daniel Lezcano wrote:
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---

Hi,

is this patch fine ? Can I pick it through my tree ?

Thanks.

   -- Daniel


>   include/linux/clk.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
>   	return NULL;
>   }
>
> +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
> +{
> +	return NULL;
> +}
>   #endif
>
>   /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub

[Michael Turquette]

Hi Daniel,

Quoting Daniel Lezcano (2016-06-02 14:41:32)
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
> =

> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

This looks OK to me. Russell maintains clkdev and the clk.h stuff, so it
would be good to get his ack. Please feel free to add:

Reviewed-by: Michael Turquette <mturquette@baylibre.com>

Regards,
Mike

> ---
>  include/linux/clk.h | 4 ++++
>  1 file changed, 4 insertions(+)
> =

> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk =
*clk)
>         return NULL;
>  }
>  =

> +static inline struct clk *clk_get_sys(const char *dev_id, const char *co=
n_id)
> +{
> +       return NULL;
> +}
>  #endif
>  =

>  /* clk_prepare_enable helps cases using clk_enable in non-atomic context=
. */
> -- =

> 1.9.1
>=20