From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <k.kozlowski@samsung.com>
Subject: Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
To: Laxman Dewangan <ldewangan@nvidia.com>, javier@osg.samsung.com,
 mturquette@baylibre.com, robh+dt@kernel.org, linux@armlinux.org.uk
References: <1466000018-16784-1-git-send-email-ldewangan@nvidia.com>
 <1466000018-16784-5-git-send-email-ldewangan@nvidia.com>
 <57627757.50101@samsung.com> <576276E5.5040500@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-samsung-soc@vger.kernel.org,
 Javier Martinez Canillas <javier@dowhile0.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <57627B4C.7060609@samsung.com>
Date: Thu, 16 Jun 2016 12:11:24 +0200
MIME-version: 1.0
In-reply-to: <576276E5.5040500@nvidia.com>
Content-type: text/plain; charset=windows-1252
List-ID: <linux-clk.vger.kernel.org>

On 06/16/2016 11:52 AM, Laxman Dewangan wrote:
> Hi Krzysztof/Javier,
> Thanks for review of the series.
> 
> I will post the V2 after taking care of all comment.
> 
> One query about the comment.
> 
> Thanks,
> Laxman
> 
> On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote:
>> On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
>>>   enum chip_name {
>>>       CHIP_MAX77686,
>>>       CHIP_MAX77802,
>>> +    CHIP_MAX77620,
>> Now it is more obvious why it is here. However I don't like the
>> duplication of device IDs, under different names and different values:
>> 1. include/linux/mfd/max77686-private.h
>> 2. include/linux/mfd/max77620.h
>> 3. here
>>
>> I was thinking about way of combining it... but these headers are
>> different. Unless there will be one header for all three devices.
>>
>> Anyway, please add the max77686 prefix to the enum.
> 
> so will it be:
> 
> enum max77686_chip_name {
>     CHIP_MAX77686,
>     CHIP_MAX77802,
>     CHIP_MAX77620,
> };
> 
> 
> Will it be fine here?

Yes, looks fine to me.

Best regards,
Krzysztof