From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
javier@osg.samsung.com, mturquette@baylibre.com,
robh+dt@kernel.org, linux@armlinux.org.uk
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver
Date: Thu, 16 Jun 2016 15:02:02 +0200 [thread overview]
Message-ID: <5762A34A.3060309@samsung.com> (raw)
In-Reply-To: <1466000018-16784-2-git-send-email-ldewangan@nvidia.com>
On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
> The clock IP used on the Maxim PMICs max77686 and max77802 are
> same. The configuration of clock register is also same except
> the number of clocks.
>
> Part of common code utilisation, there is 3 files for these chips
> clock driver, one for common and two files for driver registration.
>
> Combine both drivers into single file and move common code into
> same common file reduces the 2 files and make max77686 and max77802
> clock driver in single fine. This driver does not depends on the
> parent driver structure. The regmap handle is acquired through
> regmap APIs for the register access.
>
> This combination of driver helps on adding clock driver for different
> Maxim PMICs which has similar clock IP like MAX77620 and MAX20024.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@dowhile0.org>
> ---
> drivers/clk/Kconfig | 15 +--
> drivers/clk/Makefile | 2 -
> drivers/clk/clk-max-gen.c | 194 ------------------------------------
> drivers/clk/clk-max-gen.h | 32 ------
> drivers/clk/clk-max77686.c | 241 +++++++++++++++++++++++++++++++++++++++++----
> drivers/clk/clk-max77802.c | 96 ------------------
> 6 files changed, 225 insertions(+), 355 deletions(-)
> delete mode 100644 drivers/clk/clk-max-gen.c
> delete mode 100644 drivers/clk/clk-max-gen.h
> delete mode 100644 drivers/clk/clk-max77802.c
Tested on max77686 and max77802:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-06-16 13:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 14:13 [PATCH 0/5] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan
2016-06-15 14:13 ` [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan
2016-06-15 15:12 ` Javier Martinez Canillas
2016-06-15 15:35 ` kbuild test robot
2016-06-15 15:35 ` [PATCH] clk: max77686: fix semicolon.cocci warnings kbuild test robot
2016-06-16 9:31 ` [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Krzysztof Kozlowski
2016-06-16 13:02 ` Krzysztof Kozlowski [this message]
2016-06-15 14:13 ` [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan
2016-06-15 15:19 ` Javier Martinez Canillas
2016-06-16 9:34 ` Krzysztof Kozlowski
2016-06-16 9:44 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan
2016-06-15 15:24 ` Javier Martinez Canillas
2016-06-16 9:49 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan
2016-06-15 15:27 ` Javier Martinez Canillas
2016-06-16 9:54 ` Krzysztof Kozlowski
2016-06-16 9:52 ` Laxman Dewangan
2016-06-16 10:11 ` Krzysztof Kozlowski
2016-06-16 13:02 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan
2016-06-15 15:39 ` Javier Martinez Canillas
2016-06-16 12:25 ` Krzysztof Kozlowski
2016-06-16 13:06 ` Javier Martinez Canillas
2016-06-16 13:08 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762A34A.3060309@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=javier@osg.samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).