From: Laxman Dewangan <ldewangan@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802
Date: Tue, 28 Jun 2016 16:58:36 +0530 [thread overview]
Message-ID: <57725F64.4030903@nvidia.com> (raw)
In-Reply-To: <5768E2AD.8070004@nvidia.com>
Hi Rob,
On Tuesday 21 June 2016 12:16 PM, Laxman Dewangan wrote:
>
> On Monday 20 June 2016 10:09 PM, Rob Herring wrote:
>> On Fri, Jun 17, 2016 at 04:21:05PM +0530, Laxman Dewangan wrote:
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
>>> b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
>>> index 9c40739..4d973b5 100644
>>> --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
>>> +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
>>> @@ -1,11 +1,15 @@
>>> -Binding for Maxim MAX77686 32k clock generator block
>>> +Binding for Maxim MAX77686/MAX77802 32k clock generator block
>>> -This is a part of device tree bindings of MAX77686 multi-function
>>> device.
>>> -More information can be found in bindings/mfd/max77686.txt file.
>>> +This is a part of device tree bindings of MAX77686/MAX77802
>>> multi-function
>>> +device. More information can be found in bindings/mfd/max77686.txt
>>> file for
>>> +MAX77686 and bindings/mfd/max77802.txt for MAX77802.
>>> The MAX77686 contains three 32.768khz clock outputs that can be
>>> controlled
>>> (gated/ungated) over I2C.
>>> +The MAX77802 contains two 32.768khz clock outputs that can be
>>> controlled
>>> +(gated/ungated) over I2C.
>>> +
>>> Following properties should be presend in main device node of the
>>> MFD chip.
>>> Required properties:
>> I'd expect to see compatible strings updated...
>>
>
> There is no separate compatible string for clock. The clock nodes is
> the parent node only and the compatible described in the parent DT
> binding doc.
>
>
> Do we also need to add same thing here?
Are you fine with the above? As there is no compatible string for clock
(clock does not have separate node), do I still need to add explicitly here?
next prev parent reply other threads:[~2016-06-28 11:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 10:51 [PATCH V3 0/4] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan
2016-06-17 10:51 ` [PATCH V3 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan
2016-08-15 22:40 ` Stephen Boyd
2016-06-17 10:51 ` [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan
2016-06-20 16:39 ` Rob Herring
2016-06-21 6:46 ` Laxman Dewangan
2016-06-28 11:28 ` Laxman Dewangan [this message]
2016-08-10 9:40 ` Laxman Dewangan
2016-08-10 12:43 ` Rob Herring
2016-08-15 22:40 ` Stephen Boyd
2016-06-17 10:51 ` [PATCH V3 3/4] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan
2016-06-20 16:41 ` Rob Herring
2016-08-15 22:40 ` Stephen Boyd
2016-06-17 10:51 ` [PATCH V3 4/4] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan
2016-08-15 22:40 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57725F64.4030903@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).