From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.nawrocki@samsung.com>
Subject: Re: [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block
To: Abhilash Kesavan <a.kesavan@samsung.com>
References: <1467750561-13957-1-git-send-email-a.kesavan@samsung.com>
 <1467750561-13957-3-git-send-email-a.kesavan@samsung.com>
Cc: tomasz.figa@gmail.com, kgene.kim@samsung.com, k.kozlowski@samsung.com,
 b.zolnierkie@samsung.com, mturquette@baylibre.com, sboyd@codeaurora.org,
 linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-id: <577E2E6E.3040809@samsung.com>
Date: Thu, 07 Jul 2016 12:26:54 +0200
MIME-version: 1.0
In-reply-to: <1467750561-13957-3-git-send-email-a.kesavan@samsung.com>
Content-type: text/plain; charset=windows-1252
List-ID: <linux-clk.vger.kernel.org>

On 07/05/2016 10:29 PM, Abhilash Kesavan wrote:

> +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = {
> +	/* rate, m, p, s */
> +	PLL_35XX_RATE(2496000000, 208, 2, 0),

Please add U postfix to these constants to address compiler warning
as reported by kbuild-all@01.org:

>> drivers/clk/samsung/clk-exynos7.c:43:2: warning: this decimal constant is
unsigned only in ISO C90
     PLL_35XX_RATE(2496000000, 208, 2, 0),
     ^~~~~~~~~~~~~


> +static void __init exynos7_clk_atlas_init(struct device_node *np)
> +{
> +	void __iomem *reg_base;
> +	struct samsung_clk_provider *ctx;
> +
> +	reg_base = of_iomap(np, 0);
> +	if (!reg_base) {
> +		panic("%s: failed to map registers\n", __func__);
> +		return;
> +	}
> +
> +	ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK);
> +	if (!ctx) {
> +		panic("%s: unable to allocate ctx\n", __func__);

You can remove this panic() call, there is already one inside
samsung_clk_init().