From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mr213138.mail.yeah.net ([223.252.213.138]:40058 "EHLO mr213138.mail.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbcGLHdG (ORCPT ); Tue, 12 Jul 2016 03:33:06 -0400 Subject: Re: [PATCH v2 03/10] Clocksource: add nuc970 clocksource driver To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Daniel Lezcano References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-4-git-send-email-vw@iommu.org> <3277576.eNgdG7zPqq@wuerfel> Cc: Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun From: Wan Zongshun Message-ID: <57849D2B.60305@iommu.org> Date: Tue, 12 Jul 2016 15:32:59 +0800 MIME-Version: 1.0 In-Reply-To: <3277576.eNgdG7zPqq@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-clk-owner@vger.kernel.org List-ID: On 2016年07月11日 23:36, Arnd Bergmann wrote: > On Sunday, July 10, 2016 3:27:23 PM CEST Wan Zongshun wrote: >> >> +config NUC900_TIMER >> + bool "Clocksource timer for nuc900 platform" if COMPILE_TEST >> + depends on ARM >> + select CLKSRC_OF if OF >> + select CLKSRC_MMIO >> + help >> + Enables the clocksource for the NUC900 platform. >> > > I have put this patch into my randconfig build system and found that > it lacks a dependency: > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index e18ef32776a3..59b9251eef37 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -523,7 +523,7 @@ config CLKSRC_ST_LPC > > config NUC900_TIMER > bool "Clocksource timer for nuc900 platform" if COMPILE_TEST > - depends on ARM > + depends on ARM && GENERIC_CLOCKEVENTS > select CLKSRC_OF if OF > select CLKSRC_MMIO > help > So this patch, I still need submit or you have merged it? > > Also the init function has changed its return type in linux-next: > >> +static void __init nuc970_timer_of_init(struct device_node *node) > > This now needs to return an error code or we get: > > ../include/linux/of.h:1004:20: error: comparison of distinct pointer types lacks a cast [-Werror] > .data = (fn == (fn_type)NULL) ? fn : fn } > > Daniel Lezcano seems to have implemented a migration strategy, but I > can't see what you are supposed to do here, since the > CLOCKSOURCE_OF_DECLARE_RET macro is no longer part of linux-next. Wait for Daniel's comments? or what should I do now? > > Arnd > >