linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: samsung: Properly propagate flags in __PLL macro
       [not found] <CGME20170914143824eucas1p1e811c6c4c32a2253aebad9a27d4182d5@eucas1p1.samsung.com>
@ 2017-09-14 14:38 ` Marek Szyprowski
  2017-09-15  2:49   ` Chanwoo Choi
  2017-10-03 10:29   ` Sylwester Nawrocki
  0 siblings, 2 replies; 3+ messages in thread
From: Marek Szyprowski @ 2017-09-14 14:38 UTC (permalink / raw)
  To: linux-clk, linux-samsung-soc
  Cc: Marek Szyprowski, Sylwester Nawrocki, Chanwoo Choi,
	Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz

All users of __PLL macro already provide flags parameter, so don't
overwrite it unconditionally with CLK_GET_RATE_NOCACHE.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/clk/samsung/clk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h
index b8ca0dd3a38b..d5f0d3f818b6 100644
--- a/drivers/clk/samsung/clk.h
+++ b/drivers/clk/samsung/clk.h
@@ -305,7 +305,7 @@ struct samsung_pll_clock {
 		.dev_name	= _dname,				\
 		.name		= _name,				\
 		.parent_name	= _pname,				\
-		.flags		= CLK_GET_RATE_NOCACHE,			\
+		.flags		= _flags,				\
 		.con_offset	= _con,					\
 		.lock_offset	= _lock,				\
 		.rate_table	= _rtable,				\
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: samsung: Properly propagate flags in __PLL macro
  2017-09-14 14:38 ` [PATCH] clk: samsung: Properly propagate flags in __PLL macro Marek Szyprowski
@ 2017-09-15  2:49   ` Chanwoo Choi
  2017-10-03 10:29   ` Sylwester Nawrocki
  1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2017-09-15  2:49 UTC (permalink / raw)
  To: Marek Szyprowski, linux-clk, linux-samsung-soc
  Cc: Sylwester Nawrocki, Krzysztof Kozlowski,
	Bartlomiej Zolnierkiewicz

On 2017년 09월 14일 23:38, Marek Szyprowski wrote:
> All users of __PLL macro already provide flags parameter, so don't
> overwrite it unconditionally with CLK_GET_RATE_NOCACHE.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/clk/samsung/clk.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h
> index b8ca0dd3a38b..d5f0d3f818b6 100644
> --- a/drivers/clk/samsung/clk.h
> +++ b/drivers/clk/samsung/clk.h
> @@ -305,7 +305,7 @@ struct samsung_pll_clock {
>  		.dev_name	= _dname,				\
>  		.name		= _name,				\
>  		.parent_name	= _pname,				\
> -		.flags		= CLK_GET_RATE_NOCACHE,			\
> +		.flags		= _flags,				\
>  		.con_offset	= _con,					\
>  		.lock_offset	= _lock,				\
>  		.rate_table	= _rtable,				\
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: samsung: Properly propagate flags in __PLL macro
  2017-09-14 14:38 ` [PATCH] clk: samsung: Properly propagate flags in __PLL macro Marek Szyprowski
  2017-09-15  2:49   ` Chanwoo Choi
@ 2017-10-03 10:29   ` Sylwester Nawrocki
  1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2017-10-03 10:29 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: linux-clk, linux-samsung-soc, Chanwoo Choi, Krzysztof Kozlowski,
	Bartlomiej Zolnierkiewicz

On 09/14/2017 04:38 PM, Marek Szyprowski wrote:
> All users of __PLL macro already provide flags parameter, so don't
> overwrite it unconditionally with CLK_GET_RATE_NOCACHE.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Patch applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-03 10:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20170914143824eucas1p1e811c6c4c32a2253aebad9a27d4182d5@eucas1p1.samsung.com>
2017-09-14 14:38 ` [PATCH] clk: samsung: Properly propagate flags in __PLL macro Marek Szyprowski
2017-09-15  2:49   ` Chanwoo Choi
2017-10-03 10:29   ` Sylwester Nawrocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).