From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.samsung.com ([203.254.224.24]:56622 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbdIOCtM (ORCPT ); Thu, 14 Sep 2017 22:49:12 -0400 MIME-version: 1.0 Content-type: text/plain; charset="UTF-8" Message-id: <59BB3FA7.3070000@samsung.com> Date: Fri, 15 Sep 2017 11:49:11 +0900 From: Chanwoo Choi To: Marek Szyprowski , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Sylwester Nawrocki , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] clk: samsung: Properly propagate flags in __PLL macro In-reply-to: <1505399897-4840-1-git-send-email-m.szyprowski@samsung.com> References: <1505399897-4840-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-clk-owner@vger.kernel.org List-ID: On 2017년 09월 14일 23:38, Marek Szyprowski wrote: > All users of __PLL macro already provide flags parameter, so don't > overwrite it unconditionally with CLK_GET_RATE_NOCACHE. > > Signed-off-by: Marek Szyprowski > --- > drivers/clk/samsung/clk.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h > index b8ca0dd3a38b..d5f0d3f818b6 100644 > --- a/drivers/clk/samsung/clk.h > +++ b/drivers/clk/samsung/clk.h > @@ -305,7 +305,7 @@ struct samsung_pll_clock { > .dev_name = _dname, \ > .name = _name, \ > .parent_name = _pname, \ > - .flags = CLK_GET_RATE_NOCACHE, \ > + .flags = _flags, \ > .con_offset = _con, \ > .lock_offset = _lock, \ > .rate_table = _rtable, \ > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics