Re: [PATCH 2/8] arm64: dts: qcom: sm8350: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

Dmitry Baryshkov
2023-02-06T12:47:55Z

On 06/02/2023 13:23, Konrad Dybcio wrote:
>
>
> On 6.02.2023 12:22, Dmitry Baryshkov wrote:
>> On 06/02/2023 12:44, Konrad Dybcio wrote:
>>>
>>>
>>> On 6.02.2023 01:27, Dmitry Baryshkov wrote:
>>>> Add another power saving state used on SM8350.
>>>>
>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>> ---
>>>>   include/dt-bindings/power/qcom-rpmpd.h | 1 +
>>> Wrong patch?
>>
>> And this patch is correct. sm8350 GPU OPP table uses this value (but as doesn't reference the rpmh's opp states, we don't have to add one there).
> Okay, but it's *just* a header entry, so the subject is
> misleading and you're not adding the dt part here.

Ack, I got your point now. Yes, it should be `dt-bindings: add
RPMH_REGULATOR_LEVEL_LOW_SVS_L1'.

>
> Konrad
>>
>>>
>>> Konrad
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
>>>> index 4a30d10e6b7d..1bf8e87ecd7e 100644
>>>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>>>> @@ -211,6 +211,7 @@
>>>>   #define RPMH_REGULATOR_LEVEL_MIN_SVS    48
>>>>   #define RPMH_REGULATOR_LEVEL_LOW_SVS_D1    56
>>>>   #define RPMH_REGULATOR_LEVEL_LOW_SVS    64
>>>> +#define RPMH_REGULATOR_LEVEL_LOW_SVS_L1    80
>>>>   #define RPMH_REGULATOR_LEVEL_SVS    128
>>>>   #define RPMH_REGULATOR_LEVEL_SVS_L0    144
>>>>   #define RPMH_REGULATOR_LEVEL_SVS_L1    192
>>

--
With best wishes
Dmitry