From: Stephen Boyd <sboyd@kernel.org>
To: "Matthias Brugger" <matthias.bgg@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 3/3] clk: mediatek: Convert all remaining drivers to platform_driver's .remove_new()
Date: Wed, 10 May 2023 13:43:33 -0700 [thread overview]
Message-ID: <5e0438103c4ec0a2fadb34d7a66b82fc.sboyd@kernel.org> (raw)
In-Reply-To: <20230430190233.878921-4-u.kleine-koenig@pengutronix.de>
Quoting Uwe Kleine-König (2023-04-30 12:02:33)
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert all mediatek clk drivers from always returning zero in
> the remove callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied to clk-next
prev parent reply other threads:[~2023-05-10 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 19:02 [PATCH v2 0/3] clk: mediatek: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-30 19:02 ` [PATCH v2 1/3] clk: mediatek: Make mtk_clk_simple_remove() return void Uwe Kleine-König
2023-05-10 20:43 ` Stephen Boyd
2023-04-30 19:02 ` [PATCH v2 2/3] clk: mediatek: Make mtk_clk_pdev_remove() " Uwe Kleine-König
2023-05-10 20:43 ` Stephen Boyd
2023-04-30 19:02 ` [PATCH v2 3/3] clk: mediatek: Convert all remaining drivers to platform_driver's .remove_new() Uwe Kleine-König
2023-05-10 20:43 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0438103c4ec0a2fadb34d7a66b82fc.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox