Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

Rob Herring
2023-03-02T17:14:26Z

On Wed, Mar 1, 2023 at 7:38 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> This patch series adds unit tests for the clk fixed rate basic type and
> the clk registration functions that use struct clk_parent_data. To get
> there, we add support for loading a DTB into the UML kernel that's
> running the unit tests along with probing platform drivers to bind to
> device nodes specified in DT.
>
> With this series, we're able to exercise some of the code in the common
> clk framework that uses devicetree lookups to find parents and the fixed
> rate clk code that scans devicetree directly and creates clks. Please
> review.
>
> I Cced everyone to all the patches so they get the full context. I'm
> hoping I can take the whole pile through the clk tree as they almost all
> depend on each other. In the future I imagine it will be easy to add
> more test nodes to the clk.dtsi file and not need to go across various
> maintainer trees like this series does.
>
> Stephen Boyd (8):
> dt-bindings: Add linux,kunit binding
> of: Enable DTB loading on UML for KUnit tests
> kunit: Add test managed platform_device/driver APIs
> clk: Add test managed clk provider/consumer APIs
> dt-bindings: kunit: Add fixed rate clk consumer test
> clk: Add KUnit tests for clk fixed rate basic type
> dt-bindings: clk: Add KUnit clk_parent_data test
> clk: Add KUnit tests for clks registered with struct clk_parent_data

Good to see bindings for this. I've been meaning to do something about
the DT unittest ones being undocumented, but I hadn't really decided
whether it was worth writing schemas for them. The compatibles at
least show up with 'make dt_compatible_check'. Perhaps we want to just
define some vendor (not 'linux') that's an exception rather than
requiring schemas (actually, that already works for 'foo'). It's
likely that we want test DTs that fail normal checks and schemas get
in the way of that as we don't have a way to turn off checks.

We already have GPIO tests in the DT unittests, so why is clocks
different? Or should the GPIO tests be moved out (yes, please!)?

What happens when/if the DT unittest is converted to kunit? I think
that would look confusing from the naming. My initial thought is
'kunit' should be dropped from the naming of a lot of this. Note that
the original kunit submission converted the DT unittests. I would
still like to see that happen. Frank disagreed over what's a unit test
or not, then agreed, then didn't... I don't really care. If there's a
framework to use, then we should use it IMO.

>
> .../clock/linux,clk-kunit-parent-data.yaml | 47 ++
> .../kunit/linux,clk-kunit-fixed-rate.yaml | 35 ++
> .../bindings/kunit/linux,kunit.yaml | 24 +
> arch/um/kernel/dtb.c | 29 +-
> drivers/clk/.kunitconfig | 3 +
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 6 +
> drivers/clk/clk-fixed-rate_test.c | 296 ++++++++++++
> drivers/clk/clk-kunit.c | 204 ++++++++
> drivers/clk/clk-kunit.h | 28 ++
> drivers/clk/clk_test.c | 456 +++++++++++++++++-
> drivers/of/Kconfig | 26 +
> drivers/of/Makefile | 1 +
> drivers/of/kunit/.kunitconfig | 4 +
> drivers/of/kunit/Makefile | 4 +
> drivers/of/kunit/clk.dtsi | 30 ++
> drivers/of/kunit/kunit.dtsi | 9 +
> drivers/of/kunit/kunit.dtso | 4 +
> drivers/of/kunit/uml_dtb_test.c | 55 +++
> include/kunit/platform_driver.h | 15 +
> lib/kunit/Makefile | 6 +
> lib/kunit/platform_driver-test.c | 107 ++++
> lib/kunit/platform_driver.c | 207 ++++++++

Humm, we have DT platform driver unittests too. What's the difference?

Anyways, that's all just my initial reaction from only halfway looking
at this. :)

Rob