Re: [PATCH 07/13] dt-bindings: clock: qcom: Add SA8775P video clock controller

Krzysztof Kozlowski
2024-05-31T13:59:49Z

On 31/05/2024 11:02, Taniya Das wrote:
> Add device tree bindings for the video clock controller on Qualcomm
> SA8775P platform.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> .../bindings/clock/qcom,sa8775p-videocc.yaml | 75 +++++++++++++++++++
> .../dt-bindings/clock/qcom,sa8775p-videocc.h | 47 ++++++++++++
> 2 files changed, 122 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
> create mode 100644 include/dt-bindings/clock/qcom,sa8775p-videocc.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
> new file mode 100644
> index 000000000000..3edb29d0e5eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sa8775p-videocc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Video Clock & Reset Controller on SA8775P
> +
> +maintainers:
> + - Taniya Das <quic_tdas@quicinc.com>
> +
> +description: |
> + Qualcomm video clock control module provides the clocks, resets and power
> + domains on SA8775P.
> +
> + See also:: include/dt-bindings/clock/qcom,sa8775p-videocc.h

Just single ':'

> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sa8775p-videocc

I am not sure if you are sure what you are doing... so to clarify:
SA8775p is going significant bindings rework, so in general please post
bindings matching new firmware (so SCMI consensus) or something which
will be stable.

Don't post something which tomorrow will need changes.

Does this binding fits new style or is going to be considered stable?

> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Video AHB clock from GCC
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep Clock source
> +
> + power-domains:
> + maxItems: 1
> + description:
> + MMCX power domain.
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + '#power-domain-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - power-domains
> + - '#clock-cells'
> + - '#reset-cells'
> + - '#power-domain-cells'

Drop redundant properties and reference qcom,gcc.yaml.

> +#endif

Best regards,
Krzysztof