Re: [PATCH 09/13] dt-bindings: clock: qcom: Add SA8775P camera controller

Krzysztof Kozlowski
2024-05-31T14:10:18Z

On 31/05/2024 11:02, Taniya Das wrote:
> Add device tree bindings for the camera clock controller
> on Qualcomm SA8775P platform.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> .../bindings/clock/qcom,sa8775p-camcc.yaml | 76 +++++++++++++
> .../dt-bindings/clock/qcom,sa8775p-camcc.h | 107 ++++++++++++++++++
> 2 files changed, 183 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
> create mode 100644 include/dt-bindings/clock/qcom,sa8775p-camcc.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
> new file mode 100644
> index 000000000000..0f8e4ee5e386
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sa8775p-camcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Camera Clock & Reset Controller on SA8775P
> +
> +maintainers:
> + - Taniya Das <quic_tdas@quicinc.com>
> +
> +description: |
> + Qualcomm camera clock control module provides the clocks, resets and power
> + domains on SA8775p.
> +
> + See also::
> + include/dt-bindings/clock/qcom,sa8775p-camcc.h
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sa8775p-camcc
> +
> + clocks:
> + items:
> + - description: Camera AHB clock from GCC
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source

Same comments (see my patchset adding qcom,gcc.yaml ref).

> +
> + power-domains:
> + maxItems: 1
> + description:
> + A phandle and PM domain specifier for the MMCX power domain.

Here and in other patches, just replace it with
items:
- description: MMCX power domain

(two lines instead of three, dropping redundant pieces of sentence)

In general, please avoid making redundant code. We all understand how it
works and efficient binding or code is better than obfuscated long
sentence saying that phandle is a phandle.

Best regards,
Krzysztof