Re: [PATCH 04/13] clk: qcom: gpucc-sa8775p: Remove the CLK_IS_CRITICAL and ALWAYS_ON flags

Trilok Soni
2024-06-02T17:58:39Z

On 6/1/2024 9:08 PM, Bjorn Andersson wrote:
>>> I fail to see why this is a fix. They were marked as critical on
>>> purpose. It was needed, wasn't it?
>>>
>>> Provide jsutification for commits, not just sprinkle Fixes tag all around.
>> Taniya - please separate fixes into another series?
>>
> There's no problem including fixes in a series with other changes, but
> keeping them at the beginning of the series is generally preferred - as
> this both enable them being picked for some -fixes branch and avoid
> potential issues when backporting.

Sure, but I prefer that these fixes are not blocked by open items
and feedback to other drivers in the series. Once the fixes are reviewed
and picked up independently of the drivers later in the series then I am fine.

--
---Trilok Soni