From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, <linux-clk@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Sameer Pujar <spujar@nvidia.com>
Subject: Re: [PATCH] clk: tegra210: Fix default rates for HDA clocks
Date: Fri, 31 May 2019 15:58:53 +0100 [thread overview]
Message-ID: <5f2b8f8d-f3e5-fab8-8cf0-fa8a3e917845@nvidia.com> (raw)
In-Reply-To: <20190529134625.GD17223@ulmo>
On 29/05/2019 14:46, Thierry Reding wrote:
> On Wed, May 29, 2019 at 10:18:21AM +0100, Jon Hunter wrote:
>> Currently the default clock rates for the HDA and HDA2CODEC_2X clocks
>> are both 19.2MHz. However, the default rates for these clocks should
>> actually be 51MHz and 48MHz, respectively. Correct the default clock
>> rates for these clocks by specifying them in the clock init table for
>> Tegra210.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> drivers/clk/tegra/clk-tegra210.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Does this fix anything? Should this be backported to stable releases?
Good point. We are aligning the clock configuration with what we ship.
So I thought for completeness it would be good to test HDA playback
across the various sample-rates we support (32kHz to 192kHz) but with or
without this patch I am not hearing anything. Let me check on this with
Sameer as I would like to see if we need to mark this for stable or not.
> Acked-by: Thierry Reding <treding@nvidia.com>
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2019-05-31 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 9:18 [PATCH] clk: tegra210: Fix default rates for HDA clocks Jon Hunter
2019-05-29 13:46 ` Thierry Reding
2019-05-31 14:58 ` Jon Hunter [this message]
2019-06-05 11:30 ` Jon Hunter
2019-06-05 12:38 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f2b8f8d-f3e5-fab8-8cf0-fa8a3e917845@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox