From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03E0B2ED860; Fri, 10 Oct 2025 20:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760127111; cv=pass; b=Fu0YuXPMtHoTGphzvE+cOBBlyjPxVfuH4Tg01kdBp8Z+uPxoE2e9iD2yT/1IeU5tuQfyzdIENeqp3fYqgeu/TXSRN/scFnlqCUTqV8cKw3OEoGfr8QmcTEZUOoLmukyfE8w3bwvwgV95gOsaziQQym4tMKm0/TeC4SFsM/OW5co= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760127111; c=relaxed/simple; bh=M5oKauyEwWsIjTYVZB93DHZLpdHNPma90lVXtcExTac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Dk626jiuGfoNgiFjmhInVusUeEAGPYfIUDAz4R3wPe4Z6t2EIcVn6WnkjVZI2hKf3RP4CfgD5/ThCyBt6H5g7xE33okz2r5J3UuiL9Y9oPmsCqgr0Q0s3sZ1ZWFl1gHu4gtqLmwM+V7KHB+QnqOj3F3hFyUIfh9ZRmT1gtDs8YQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=H2YgkM+1; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="H2YgkM+1" ARC-Seal: i=1; a=rsa-sha256; t=1760127089; cv=none; d=zohomail.com; s=zohoarc; b=EI2xlznajdS4gA6yfY0iLVHeGnucED1Wgn8TpST2u3yDoShxRMMoH9VJrSrDBe9w5NfMH0oaNi/V83fAP/O8QYOYEaMTMWeEOQeY1GIuZ05CZ4kjbTw8KjArHrccF1ZJiv0gxo6oqoeoIoHGoSRPJ/j+RSpvrWIxxrQoH+dahYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760127089; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=x+uMFd00/VwF8oeUIUOAUFn81GsHq1DT13skkBivkHM=; b=O11ybemPA8l7ORp/8KtHX+NNOtDS5DuujWGHIXNtJceJfWCgvv/KAFBwJXuJGUgWuLJwRKsm+hah6bwntkdSLJmultv2PNAa8pwlll6rPNu8vK2lUHNCjPcBGioYy0TQJTnq9pUIGMr6Dxo6U4Btq6Ze8Jwy34CgOJ/2LCmI7IM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760127089; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=x+uMFd00/VwF8oeUIUOAUFn81GsHq1DT13skkBivkHM=; b=H2YgkM+1i+b6xb991wApukruxQ+W9Guu9g3V2wDUCgHg2vZJyIxEIi4nw7y8IqY/ Q+Y5IzE+dHXMgvpxYooxEHn+Qf39+j0yoi+9/e6gN/C+IY7awMPMWkqn08sdLchNxw6 sjsrStUMJ9fNJx227Ad3PEIxA5z0V2FXh6hSAXyU= Received: by mx.zohomail.com with SMTPS id 176012708724740.640376685993374; Fri, 10 Oct 2025 13:11:27 -0700 (PDT) From: Nicolas Frattaroli To: AngeloGioacchino Del Regno , Chen-Yu Tsai Cc: Michael Turquette , Stephen Boyd , Dong Aisheng , Matthias Brugger , Yassine Oudjana , Laura Nao , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado , Chia-I Wu , kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/5] clk: mediatek: Refactor pll registration to pass device Date: Fri, 10 Oct 2025 22:11:20 +0200 Message-ID: <6009277.31r3eYUQgx@workhorse> In-Reply-To: References: <20251008-mtk-pll-rpm-v2-0-170ed0698560@collabora.com> <2477df4e-c89e-408f-bb2a-d5af51f78ef8@collabora.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Thursday, 9 October 2025 10:18:42 Central European Summer Time Chen-Yu T= sai wrote: > On Thu, Oct 9, 2025 at 4:09=E2=80=AFPM AngeloGioacchino Del Regno > wrote: > > > > Il 08/10/25 18:05, Nicolas Frattaroli ha scritto: > > > As it stands, mtk_clk_register_plls takes a struct device_node pointer > > > as its first argument. This is a tragic happenstance, as it's trivial= to > > > get the device_node from a struct device, but the opposite not so muc= h. > > > The struct device is a much more useful thing to have passed down. > > > > > > Refactor mtk_clk_register_plls to take a struct device pointer instead > > > of a struct device_node pointer, and fix up all users of this functio= n. > > > > > > Signed-off-by: Nicolas Frattaroli > > > --- > > > drivers/clk/mediatek/clk-mt2701.c | 2 +- > > > drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-mt6735-apmixedsys.c | 4 ++-- > > > drivers/clk/mediatek/clk-mt6765.c | 2 +- > > > drivers/clk/mediatek/clk-mt6779.c | 2 +- > > > drivers/clk/mediatek/clk-mt6797.c | 2 +- > > > drivers/clk/mediatek/clk-mt7622-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-mt7629.c | 2 +- > > > drivers/clk/mediatek/clk-mt7981-apmixed.c | 2 +- > > > drivers/clk/mediatek/clk-mt7986-apmixed.c | 2 +- > > > drivers/clk/mediatek/clk-mt7988-apmixed.c | 2 +- > > > drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 3 ++- > > > drivers/clk/mediatek/clk-mt8167-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-mt8183-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-mt8188-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-mt8195-apusys_pll.c | 3 ++- > > > drivers/clk/mediatek/clk-mt8196-apmixedsys.c | 3 ++- > > > drivers/clk/mediatek/clk-mt8196-mcu.c | 2 +- > > > drivers/clk/mediatek/clk-mt8196-mfg.c | 2 +- > > > drivers/clk/mediatek/clk-mt8196-vlpckgen.c | 2 +- > > > drivers/clk/mediatek/clk-mt8365-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-mt8516-apmixedsys.c | 2 +- > > > drivers/clk/mediatek/clk-pll.c | 7 ++++--- > > > drivers/clk/mediatek/clk-pll.h | 6 +++--- > > > 24 files changed, 33 insertions(+), 29 deletions(-) > > > > > > > ..snip.. > > > > > diff --git a/drivers/clk/mediatek/clk-pll.h b/drivers/clk/mediatek/cl= k-pll.h > > > index d71c150ce83e4bb2fe78290c2d5570a90084246d..0e2b94b9cd4b56adceee3= b04e9ab24c2526471da 100644 > > > --- a/drivers/clk/mediatek/clk-pll.h > > > +++ b/drivers/clk/mediatek/clk-pll.h > > > @@ -78,9 +78,9 @@ struct mtk_clk_pll { > > > const struct mtk_pll_data *data; > > > }; > > > > > > > There's a forward declaration of struct device_node in this header: wit= h this > > change, that becomes unused. > > > > Please change that to a forward declaration of struct device instead. > > > > While at it, I'd appreciate if you could either: > > A. Remove the forward declaration for `struct clk_hw_onecell_data` an= d for > > `struct clk_ops` (as both come from clk-provider.h - which this al= ready > > includes); > > ...or... > > B. Remove the inclusion of clk-provider.h and keep the forward declar= ations. >=20 > Prefer (B) since no APIs from clk-provider.h are referenced in the header. > It is up to the implementation to directly include any and all headers it > needs. drivers/clk/mediatek/clk-pll.h:67:16: error: field has incomplete type 's= truct clk_hw' 67 | struct clk_hw hw; | ^ drivers/clk/mediatek/clk-pll.h:67:9: note: forward declaration of 'struct= clk_hw' 67 | struct clk_hw hw; | ^ The compiler needs to know the complete type here, as it's not a pointer but a member proper, which is needed for the container_of macro to work. In other words, clk-provider.h is needed. Kind regards, Nicolas Frattaroli >=20 > ChenYu >=20 > > After which: > > > > Reviewed-by: AngeloGioacchino Del Regno > > > > > -int mtk_clk_register_plls(struct device_node *node, > > > - const struct mtk_pll_data *plls, int num_plls, > > > - struct clk_hw_onecell_data *clk_data); > > > +int mtk_clk_register_plls(struct device *dev, const struct mtk_pll_d= ata *plls, > > > + int num_plls, struct clk_hw_onecell_data *clk= _data); > > > + > > > void mtk_clk_unregister_plls(const struct mtk_pll_data *plls, int n= um_plls, > > > struct clk_hw_onecell_data *clk_data); > > > > > > > > > > >=20